#8611 closed feature (wontfix)

Opened October 01, 2012 12:04PM UTC

Closed October 15, 2012 03:54PM UTC

Tab navigation slow in dialogs with large DOM

Reported by: olejorgenb Owned by:
Priority: minor Milestone: 1.10.0
Component: ui.dialog Version: 1.8.23
Keywords: Cc:
Blocked by: Blocking:
Description

http://jsfiddle.net/L8HT3/4/ (try navigation with the tab key. There's a noticable slowdown)

The "offender" is 

uiDialog.bind( "keydown.ui-dialog", function( event ) {

that ends up checking :visible on a TON of elements. (via :focusable)

Attachments (0)
Change History (5)

Changed October 01, 2012 12:50PM UTC by scottgonzalez comment:1

summary: Tabnavigation slow in dialogs with large DOM → Tab navigation slow in dialogs with large DOM

The only solution is to cache the list of tabbable elements and then add a refresh method which will update the cache so that we can support dynamic content inside dialogs.

Changed October 01, 2012 02:59PM UTC by olejorgenb comment:2

It wouldn't be possible to bind on keyup and check if the element gaining focus is inside the dialog, otherwise reversing the tab? Might cause visual glitches though :(

Changed October 01, 2012 03:03PM UTC by scottgonzalez comment:3

That would let focus move out and then back in which would cause issues.

Changed October 11, 2012 02:47PM UTC by scottgonzalez comment:4

milestone: 1.9.0 → 1.10.0

Changed October 15, 2012 03:54PM UTC by drewkimrey comment:5

resolution: → wontfix
status: new → closed

This seems to be an edge case. I would suggest either not using modal, or perhaps try using a custom solution outside of dialog. IE: show hidden div, or something simliar.