#9268 closed bug (duplicate)

Opened May 02, 2013 08:58AM UTC

Closed May 02, 2013 12:13PM UTC

Accordion widget refresh method sets active option to 0 when it was set to false

Reported by: StevenE Owned by:
Priority: minor Milestone: none
Component: ui.accordion Version: 1.10.2
Keywords: Cc:
Blocked by: Blocking:
Description

Dear,

The accordion widget refresh method sets the active option to 0 if it was set to false.

I had a look at the code and I think the solution is easy: just change the "if" on line 6235 to an "else if" and the problem is solved.

Kind regards,

Steven Engels.

Attachments (0)
Change History (5)

Changed May 02, 2013 10:09AM UTC by tj.vantoll comment:1

resolution: → notabug
status: new → closed

Using the boolean version of the 

active
option requires you to set the 
collapsible
option to 
true
. If you pass 
{active: false
} without setting 
collapsible
, it is indeed changed to 
0
. But that is because 
false
is an invalid value.

This appears to be working just fine: http://jsfiddle.net/tj_vantoll/RxaqD/. If you are still having issues let us know.

Changed May 02, 2013 11:56AM UTC by StevenE comment:2

Replying to [comment:1 tj.vantoll]:

Using the boolean version of the 
active
option requires you to set the 
collapsible
option to 
true
. If you pass 
{active: false
} without setting 
collapsible
, it is indeed changed to 
0
. But that is because 
false
is an invalid value. This appears to be working just fine: http://jsfiddle.net/tj_vantoll/RxaqD/. If you are still having issues let us know.

It seems there is a mismatch between the github version and the distributed version. jsfiddle references to the github version and there this issue has indeed been fixed by the fix I suggested. If you change the reference in jsfiddle to http://code.jquery.com/ui/1.10.2/jquery-ui.js you can see the problem still exists there. I updated your jsfiddle http://jsfiddle.net/RxaqD/2/

But if it is solved on github I assume it will get solved in the distributed version too next time it gets released.

thx, for the help.

Changed May 02, 2013 12:13PM UTC by tj.vantoll comment:3

Replying to [comment:2 StevenE]:

Replying to [comment:1 tj.vantoll]: > Using the boolean version of the 
active
option requires you to set the 
collapsible
option to 
true
. If you pass 
{active: false
} without setting 
collapsible
, it is indeed changed to 
0
. But that is because 
false
is an invalid value. > > This appears to be working just fine: http://jsfiddle.net/tj_vantoll/RxaqD/. If you are still having issues let us know. It seems there is a mismatch between the github version and the distributed version. jsfiddle references to the github version and there this issue has indeed been fixed by the fix I suggested. If you change the reference in jsfiddle to http://code.jquery.com/ui/1.10.2/jquery-ui.js you can see the problem still exists there. I updated your jsfiddle http://jsfiddle.net/RxaqD/2/ But if it is solved on github I assume it will get solved in the distributed version too next time it gets released. thx, for the help.

Ah, yeah you're right. This is a duplicate of #9189 which was fixed in 1.10.3 and will be released soon.

Changed May 02, 2013 12:13PM UTC by tj.vantoll comment:4

resolution: notabug
status: closed → reopened

Changed May 02, 2013 12:13PM UTC by tj.vantoll comment:5

resolution: → duplicate
status: reopened → closed

Duplicate of #9189.