Search and Top Navigation
#9541 closed feature (fixed)
Opened September 06, 2013 01:03PM UTC
Closed October 27, 2015 01:42PM UTC
Button: Use control.labels if available
| Reported by: | scottgonzalez | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.12.0 |
| Component: | ui.button | Version: | 1.10.3 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-lfe-labels
This should improve performance where supported.
Attachments (0)
Change History (4)
Changed September 06, 2013 05:21PM UTC by comment:1
| status: | new → open |
|---|
Changed September 07, 2013 01:48PM UTC by comment:2
| description: | http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-label-control \ \ This should improve performance where supported. → http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-lfe-labels \ \ This should improve performance where supported. |
|---|---|
| summary: | Button: Use label.control if available → Button: Use control.labels if available |
Turns out we always search in the opposite direction. Updating to use control.labels instead of label.control.
Changed April 21, 2014 10:20AM UTC by comment:3
This is being implemented in the button rewrite: https://github.com/jquery/jquery-ui/pull/1216
Changed October 27, 2015 01:42PM UTC by comment:4
| milestone: | none → 1.12.0 |
|---|---|
| resolution: | → fixed |
| status: | open → closed |
Confirmed fixed in master.
We can check the
controlproperty without doing any feature detection. If the result isundefined, then we need to query for the associated control. If it'snull, then there is no associated control.