Search and Top Navigation
#9759 closed bug (notabug)
Opened January 21, 2014 10:55AM UTC
Closed April 03, 2014 07:18PM UTC
Last modified May 16, 2014 12:09PM UTC
Dialog: Broken images on CDN and quick download
Reported by: | Choppel | Owned by: | |
---|---|---|---|
Priority: | blocker | Milestone: | 1.11.0 |
Component: | ui.dialog | Version: | 1.10.4 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
When creating a modal dialog the background is not continuously one colour.
Attachments (0)
Change History (16)
Changed January 21, 2014 03:05PM UTC by comment:1
status: | new → open |
---|---|
summary: | Modal Dialog - Overlay is not continuous → Dialog - Issue with overlay image |
Changed February 05, 2014 11:39PM UTC by comment:3
comparison of some images: http://jsfiddle.net/FlasJunior/zfEAQ/9/
Changed March 05, 2014 05:15PM UTC by comment:5
milestone: | none → 1.11.0 |
---|---|
priority: | minor → blocker |
Changed March 17, 2014 06:26PM UTC by comment:6
summary: | Dialog - Issue with overlay image → Dialog: Broken images on CDN and quick download |
---|
Changed March 23, 2014 04:32PM UTC by comment:8
The resize icons on dialogs is broken as well; see http://jqueryui.com/dialog/#modal and notice that:
(i) the horizontal bar is there (set the background-image to none might fix this)
(ii) bottom right corner has resize handle but no icon (background image position is wrong)
Changed March 23, 2014 05:55PM UTC by comment:9
Replying to [comment:8 schwarzenneger]:
The resize icons on dialogs is broken as well
That's unrelated and not broken. See #4575.
Changed April 01, 2014 04:33PM UTC by comment:10
Live download builder produces correct images. For example:
1.10.3: http://code.jquery.com/ui/1.10.3/themes/smoothness/images/ui-bg_flat_0_aaaaaa_40x100.png
live: http://download.jqueryui.com/themeroller/images/ui-bg_flat_0_aaaaaa_40x100.png
Issue might have happened during release.
Changed April 01, 2014 04:46PM UTC by comment:11
Although themeroller code is supposed to work using any ImageMagick version (https://github.com/jquery/download.jqueryui.com/issues/132). It's true for linux. But, not for mac (https://github.com/jquery/download.jqueryui.com/issues/144).
So, we need to either: (a) figure out what's wrong with #144 on Mac; or (b) release packages using a controlled environment.
Changed April 03, 2014 07:18PM UTC by comment:12
resolution: | → notabug |
---|---|
status: | open → closed |
We've addressed the cause of the issue, so I'm now going to close this, even though the CDNs will forever host the broken images. This will be closed as not a bug since it has nothing to do with the source code of jQuery UI.
Changed May 09, 2014 11:48AM UTC by comment:13
#10031 is a duplicate of this ticket.
Changed May 10, 2014 12:13PM UTC by comment:14
#10033 is a duplicate of this ticket.
Changed May 13, 2014 12:02PM UTC by comment:15
#10041 is a duplicate of this ticket.
Changed May 16, 2014 12:09PM UTC by comment:16
#10044 is a duplicate of this ticket.
Hmmm... it looks like something went wrong with the images generated in 1.10.4.
http://code.jquery.com/ui/1.10.3/themes/smoothness/images/ui-bg_flat_0_aaaaaa_40x100.png
vs
http://code.jquery.com/ui/1.10.4/themes/smoothness/images/ui-bg_flat_0_aaaaaa_40x100.png