Opened 5 years ago

Closed 2 years ago

Last modified 2 years ago

#10122 closed bug (fixed)

adding role=presentation to anchors is invalid

Reported by: xrchz Owned by: xrchz
Priority: minor Milestone: 1.12.2
Component: ui.tabs Version: 1.9.0
Keywords: Cc:
Blocked by: Blocking:

Description

It looks like the tabs widget adds a role=presentation attribute to anchors, here: https://github.com/jquery/jquery-ui/blob/master/ui/tabs.js#L410

This is not a valid value for the role of an anchor, according to this: http://www.w3.org/html/wg/drafts/html/master/dom.html#sec-implicit-aria-semantics

I'm not sure why this attribute was added so I don't want to just delete it, but maybe it should be deleted or replaced with something else.

Change History (5)

comment:1 Changed 5 years ago by Scott González

Owner: set to xrchz
Status: newpending

Do you have an example of this causing problems?

comment:2 Changed 5 years ago by xrchz

Status: pendingnew

It depends what you mean by "problems". It makes my page fail HTML validation. Does it do something useful? If so maybe we can find a standards compliant way to do that instead.(If not, just delete it.)

comment:3 Changed 3 years ago by みるく

I have a fix, fork the ​repository on GitHub and send a pull request. https://github.com/jquery/jquery-ui/pull/1748

comment:4 Changed 2 years ago by Scott González

Resolution: fixed
Status: newclosed

In b9ffc34:

Tabs: Remove presentation role

Fixes #10122
Closes gh-1748

comment:5 Changed 2 years ago by Scott González

Milestone: none1.12.2
Version: git (not yet released)1.9.0
Note: See TracTickets for help on using tickets.