Skip to main content

Search and Top Navigation

#10122 closed bug (fixed)

Opened June 22, 2014 06:11AM UTC

Closed September 29, 2016 02:17PM UTC

Last modified September 29, 2016 02:18PM UTC

adding role=presentation to anchors is invalid

Reported by: xrchz Owned by: xrchz
Priority: minor Milestone: 1.12.2
Component: ui.tabs Version: 1.9.0
Keywords: Cc:
Blocked by: Blocking:

It looks like the tabs widget adds a role=presentation attribute to anchors, here:

This is not a valid value for the role of an anchor, according to this:

I'm not sure why this attribute was added so I don't want to just delete it, but maybe it should be deleted or replaced with something else.

Attachments (0)
Change History (5)

Changed June 22, 2014 02:25PM UTC by scottgonzalez comment:1

owner: → xrchz
status: newpending

Do you have an example of this causing problems?

Changed June 22, 2014 04:17PM UTC by xrchz comment:2

status: pendingnew

It depends what you mean by "problems". It makes my page fail HTML validation. Does it do something useful? If so maybe we can find a standards compliant way to do that instead.(If not, just delete it.)

Changed September 18, 2016 10:39AM UTC by milk54 comment:3

I have a fix, fork the ​repository on GitHub and send a pull request.

Changed September 29, 2016 02:17PM UTC by scottgonzalez comment:4

resolution: → fixed
status: newclosed

In [changeset:"b9ffc34710212fd910717ab735818ef265c9372e" b9ffc34]:

#!CommitTicketReference repository="" revision="b9ffc34710212fd910717ab735818ef265c9372e"
Tabs: Remove presentation role

Fixes #10122
Closes gh-1748

Changed September 29, 2016 02:18PM UTC by scottgonzalez comment:5

milestone: none1.12.2
version: git (not yet released)1.9.0