Opened 9 years ago
Last modified 6 years ago
#10658 reopened bug
Slider: handle is not mirrored in RTL mode
Reported by: | Rock | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | none |
Component: | ui.slider | Version: | 1.11.1 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
Should slider handle start from right in rtl mode? And arrow keyboard support should be reversed also. I'd like to provide a fix if this confirmed as a open defect, thanks!
Change History (8)
comment:1 Changed 9 years ago by
Resolution: | → notabug |
---|---|
Status: | new → closed |
comment:2 Changed 9 years ago by
Thanks for the comment, and after looking through html rendering spec in w3c, http://www.w3.org/TR/html5/rendering.html#the-input-element-as-a-range-control. It said that- "...with the lowest value on the right if the 'direction' property on this element has a computed value of 'rtl', and on the left otherwise...", so I think it's better to mirror slider in rtl mode, right?
comment:3 Changed 9 years ago by
Test case: http://jsfiddle.net/aaq0sdwn/, <body> in testcase has attribute "dir=rtl"
comment:4 Changed 9 years ago by
Component: | [meta] ui.a11y → ui.slider |
---|---|
Resolution: | notabug |
Status: | closed → reopened |
comment:5 Changed 6 years ago by
this issue may require large rewrite of positioning and input routines, so there is no local solution. you may use modified slider with option: direction=true, which inverts scale from [0..100] to [100..0].
comment:6 Changed 6 years ago by
I'm not sure what you're talking about. There is no direction
option.
comment:7 Changed 6 years ago by
I agree with Rock. The Slider handle should start from right in RTL mode. This is the expected behavior for the Arabic/Hebrew users or any RTL speaking countries. I've proposed some code changes to handle this issue here https://github.com/jquery/jquery-ui/pull/1682/commits/c92c2992e38777d92efde91f4b1b8aa8ae244350. I hope you take a look and review it.
comment:8 Changed 6 years ago by
Dears,
Appreciate if you can review Ahmed code https://github.com/jquery/jquery-ui/pull/1682/commits/c92c2992e38777d92efde91f4b1b8aa8ae244350. As it should fix this issue.
Please ensure these are necessary before filing all of these bugs.