Opened 4 years ago

Closed 3 years ago

#10666 closed bug (invalid)

$.ui.ddmanager.current not released on droppable _destroy

Reported by: eshcharc Owned by: eshcharc
Priority: minor Milestone: none
Component: ui.droppable Version: 1.11.1
Keywords: Cc:
Blocked by: Blocking:

Description

In the days of client side frameworks and SPAs, considerations need to be made regarding client side page switch and optimizations and cleaning of assets.

When we examined and profiled our SPA on a page switch scenario, we've noticed that a jQuery-UI plugin is holding a whole element tree. A further examination led us to a droppable and the "global" $.ui.ddmanager.current.

It seems that when a droppable is being destryed via _destroy, $.ui.ddmanager.current which is linked to this droppable, is not taken care of and keep a reference to the droppable and all of its tree elements. When a client side framework is involved, that makes it worse.

That can quite easily be treated.

Change History (2)

comment:1 Changed 3 years ago by tj.vantoll

Owner: set to eshcharc
Status: newpending

Hi eshcharc,

This is a valid concern for draggable, but why does it matter for droppable? Droppable just reads $.ui.ddmanager.current, so I'm not sure why it would need to clean it up during destroy().

comment:2 Changed 3 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.