Opened 8 years ago
Closed 8 years ago
#11054 closed bug (fixed)
selectmenu content differs when created or refreshed when overriding _renderItem
Reported by: | gibe | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.12.0 |
Component: | ui.selectmenu | Version: | 1.11.2 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
When creating a selectmenu, the content of the button is the text of the selected option in the original menu.
When refreshing a selectememu, the content of the button is the text of the selected <li>
in the menu widget.
By default both of the same, but when overriding _renderItem
their content may differ.
The lines setting the text are:
- for creation (l108):
this._setText( this.buttonText, this.element.find( "option:selected" ).text() );
- for refresh (l194):
this._setText( this.buttonText, this._getSelectedItem().text() );
I guess that both values make sense. However only one should be set.
Change History (1)
comment:1 Changed 8 years ago by
Milestone: | none → 1.12.0 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
This code no longer exists in master. See #10142.
Fixed by fb4124b7af4e87712eca9893f7aefb5fee7905de.