Search and Top Navigation
#14764 closed bug (worksforme)
Opened November 01, 2015 01:14AM UTC
Closed November 01, 2015 03:28AM UTC
menu item without text becomes a divider
| Reported by: | andrewoxenburgh | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | none |
| Component: | ui.menu | Version: | 1.11.3 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
I would like to be able to have a menu consisting of only icons or images.
Currently that's not possible, and an item without text becomes a divider, and will behave oddly.
jsfiddle - http://jsfiddle.net/andrewox/vo6Lchz8/
github - https://github.com/andrew-oxenburgh/jquery-ui
I ran a full grunt on this.
-
ui/widgets/menu.js:515
_isDivider: function( item ) {
// Match hyphen, em dash, en dash
return !/[^\\-\\u2014\\u2013\\s]/.test( item.text() );
},
The fix was to add a check for dom children.
Attachments (0)
Change History (1)
Changed November 01, 2015 03:28AM UTC by comment:1
| resolution: | → worksforme |
|---|---|
| status: | new → closed |
There should still be some textual representation or this won't be accessible. See http://jsfiddle.net/vo6Lchz8/1/