Opened 3 years ago

Closed 3 years ago

#14959 closed bug (notabug)

Controlgroup: Pass direction to widget options in _initWidget()

Reported by: Gabriel "_|Nix|_" Schulhof Owned by: Gabriel "_|Nix|_" Schulhof
Priority: minor Milestone: none
Component: ui.controlgroup Version: git (not yet released)
Keywords: Cc:
Blocked by: Blocking:

Description

At

https://github.com/jquery/jquery-ui/blob/010f5f9d13b7d6f1c13482825547ee95d3033e40/ui/widgets/controlgroup.js#L105

the controlgroup should also pass the direction to the widget options function, because it doesn't later end up using the options for widgets in the middle, only for first and last widgets.

Change History (5)

comment:1 Changed 50 years ago by Gabriel "_|Nix|_" Schulhof

Status: pendingnew

comment:1 Changed 3 years ago by Gabriel "_|Nix|_" Schulhof

OK, NM. I see that direction has been removed from the call to the widget options in master, so direction needs to be determined inside the options function if needed.

comment:2 Changed 3 years ago by Scott González

Owner: set to Gabriel "_|Nix|_" Schulhof
Status: newpending

Can you please explain the bug, not the requested implementation? Also, I assume that git is not the correct version and you're seeing this behavior in one of the pre-releases.

comment:3 Changed 3 years ago by Gabriel "_|Nix|_" Schulhof

It's not a bug. Sorry! I would've closed the ticket, but I don't have the permission to do so. Please close the ticket :)

comment:4 Changed 3 years ago by Scott González

Resolution: notabug
Status: newclosed
Note: See TracTickets for help on using tickets.