Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#14963 closed feature (fixed)

Restore $.ui.intersect()

Reported by: mohs8421 Owned by: Scott González
Priority: blocker Milestone: 1.12.2
Component: ui.droppable Version: 1.12.0-rc.2
Keywords: Cc:
Blocked by: Blocking:

Description

https://bugs.jqueryui.com/ticket/10534

removing this makes it impossible to implement a custom intersect method. For example if the draggable is larger than the droppable the intersect function does only work if it is centrally over the droppable, not "intersecting". I suggest to accept a function in toleranceMode and use that if provided.

Change History (5)

comment:1 Changed 3 years ago by Scott González

Milestone: none1.12.0
Priority: minorblocker
Status: newopen
Summary: Replace $.ui.intersect instead of removing itRestore $.ui.intersect()
Type: bugfeature

Ultimately, this will be handled by #4737, but that won't be available until the rewrite lands. You can see how this will work by looking at the current progress of the rewrite: https://github.com/jquery/jquery-ui/blob/c15481eeb1806938ce2b3adfa1866e5a8a78fa31/ui/droppable.js#L164

Since that won't help you for 1.12, we'll just restore $.ui.intersect() until the droppable rewrite can be released.

comment:2 Changed 3 years ago by Scott González

Owner: set to Scott González
Resolution: fixed
Status: openclosed

In f928f25:

Droppable: Re-expose $.ui.intersect()

Fixes #14963
Ref #10534

comment:3 Changed 2 years ago by Evelyn

It appears from my testing that the re-exposed $.ui.intersect is not actually used internally by ui.droppable. So changing that variable does not actually allow you to change the behavior of droppable.

Test case at http://codepen.io/outofambit/pen/zKEwdR

I tried both v1.12.0 and v1.12.1 of jQuery UI

comment:4 Changed 2 years ago by Scott González

Milestone: 1.12.01.12.2
Last edited 2 years ago by Ryan J Ollos (previous) (diff)

comment:5 Changed 2 years ago by Scott González

In fd30534:

Droppable: Use $.ui.intersect()

Fixes #14963

Note: See TracTickets for help on using tickets.