#14963 closed feature (fixed)

Opened May 04, 2016 01:58PM UTC

Closed May 04, 2016 10:49PM UTC

Last modified October 09, 2016 02:36PM UTC

Restore $.ui.intersect()

Reported by: mohs8421 Owned by: scottgonzalez
Priority: blocker Milestone: 1.12.2
Component: ui.droppable Version: 1.12.0-rc.2
Keywords: Cc:
Blocked by: Blocking:
Description

https://bugs.jqueryui.com/ticket/10534

removing this makes it impossible to implement a custom intersect method. For example if the draggable is larger than the droppable the intersect function does only work if it is centrally over the droppable, not "intersecting".

I suggest to accept a function in toleranceMode and use that if provided.

Attachments (0)
Change History (5)

Changed May 04, 2016 04:15PM UTC by scottgonzalez comment:1

milestone: none → 1.12.0
priority: minor → blocker
status: new → open
summary: Replace $.ui.intersect instead of removing it → Restore $.ui.intersect()
type: bug → feature

Ultimately, this will be handled by #4737, but that won't be available until the rewrite lands. You can see how this will work by looking at the current progress of the rewrite: https://github.com/jquery/jquery-ui/blob/c15481eeb1806938ce2b3adfa1866e5a8a78fa31/ui/droppable.js#L164

Since that won't help you for 1.12, we'll just restore $.ui.intersect() until the droppable rewrite can be released.

Changed May 04, 2016 10:49PM UTC by scottgonzalez comment:2

owner: → scottgonzalez
resolution: → fixed
status: open → closed

In [changeset:"f928f258b7978980a5f101b54f06778d14d219df" f928f25]:

#!CommitTicketReference repository="" revision="f928f258b7978980a5f101b54f06778d14d219df"
Droppable: Re-expose 

Fixes #14963
Ref #10534

Changed October 01, 2016 10:24PM UTC by outofambit comment:3

It appears from my testing that the re-exposed $.ui.intersect is not actually used internally by ui.droppable. So changing that variable does not actually allow you to change the behavior of droppable.

Test case at http://codepen.io/outofambit/pen/zKEwdR

I tried both v1.12.0 and v1.12.1 of jQuery UI

Changed October 03, 2016 01:18PM UTC by rjollos comment:4

_comment0: Fixed in [https://github.com/jquery/jquery-ui/commit/fd30534b73eaf9c076f93a349dbe0c7a77efc209 fd30534b73eaf9c076f93a349dbe0c7a77efc209]. → 1476023761699889
milestone: 1.12.0 → 1.12.2

Changed October 09, 2016 02:35PM UTC by scottgonzalez comment:5

In [changeset:"fd30534b73eaf9c076f93a349dbe0c7a77efc209" fd30534]:

#!CommitTicketReference repository="" revision="fd30534b73eaf9c076f93a349dbe0c7a77efc209"
Droppable: Use 

Fixes #14963