Opened 3 years ago

Closed 3 years ago

#15013 closed bug (wontfix)

Hidden tab can be navigated to via keyboard

Reported by: mkrajew Owned by: mkrajew
Priority: minor Milestone: none
Component: ui.tabs Version: 1.12.0
Keywords: Cc:
Blocked by: Blocking:

Description

When a tab is hidden, you can still get to its content via keyboard navigation. Tab headers that are hidden should be skipped over when navigating using the arrow keys. http://jsfiddle.net/L06qb3pz/

Change History (5)

comment:1 Changed 3 years ago by Scott González

Status: newopen

comment:2 Changed 3 years ago by Scott González

Owner: set to mkrajew
Status: openpending

Can you explain why you're hiding tabs as opposed to removing them or making them disabled?

comment:3 Changed 3 years ago by Scott González

Status: pendingopen

We're not going to handle this automatically, you'll need to call refresh() once that's implemented. For now, you should just manually disable the hidden tabs.

See https://github.com/jquery/jquery-ui/pull/1724#issuecomment-237290200 for more information.

comment:4 Changed 3 years ago by Scott González

Thinking about this some more, manually disabling the tabs wouldn't be a good solution. When the user shows the tabs again, we can't auto-enable them on the next call to refresh() after they've become visible again. We'd need to also internally track which tabs were implicitly disabled vs. explicitly disabled. I'm now inclined to go with Alex's original thought and say that this is not something we will handle and the user should explicitly disable the tabs when hiding them. If the developer never has disabled tabs other than hidden tabs, they can even do the hiding via CSS with .ui-tab.ui-state-disabled { display: none; }.

comment:5 Changed 3 years ago by Scott González

Resolution: wontfix
Status: openclosed

The team agrees that we shouldn't change anything.

Note: See TracTickets for help on using tickets.