Search and Top Navigation
#15013 closed bug (wontfix)
Opened July 21, 2016 07:26PM UTC
Closed August 17, 2016 04:14PM UTC
Hidden tab can be navigated to via keyboard
| Reported by: | mkrajew | Owned by: | mkrajew |
|---|---|---|---|
| Priority: | minor | Milestone: | none |
| Component: | ui.tabs | Version: | 1.12.0 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
When a tab is hidden, you can still get to its content via keyboard navigation. Tab headers that are hidden should be skipped over when navigating using the arrow keys.
Attachments (0)
Change History (5)
Changed July 25, 2016 01:05PM UTC by comment:1
| status: | new → open |
|---|
Changed July 25, 2016 01:24PM UTC by comment:2
| owner: | → mkrajew |
|---|---|
| status: | open → pending |
Can you explain why you're hiding tabs as opposed to removing them or making them disabled?
Changed August 03, 2016 04:31PM UTC by comment:3
| status: | pending → open |
|---|
We're not going to handle this automatically, you'll need to call refresh() once that's implemented. For now, you should just manually disable the hidden tabs.
See https://github.com/jquery/jquery-ui/pull/1724#issuecomment-237290200 for more information.
Changed August 04, 2016 12:47PM UTC by comment:4
Thinking about this some more, manually disabling the tabs wouldn't be a good solution. When the user shows the tabs again, we can't auto-enable them on the next call to refresh() after they've become visible again. We'd need to also internally track which tabs were implicitly disabled vs. explicitly disabled. I'm now inclined to go with Alex's original thought and say that this is not something we will handle and the user should explicitly disable the tabs when hiding them. If the developer never has disabled tabs other than hidden tabs, they can even do the hiding via CSS with .ui-tab.ui-state-disabled { display: none; }.
Changed August 17, 2016 04:14PM UTC by comment:5
| resolution: | → wontfix |
|---|---|
| status: | open → closed |
The team agrees that we shouldn't change anything.
PR: https://github.com/jquery/jquery-ui/pull/1724