Opened 7 years ago
Closed 7 years ago
#15016 closed bug (fixed)
dialog: button icons settings have no effect
| Reported by: | Harpo Jaeger | Owned by: | Scott González |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.12.1 |
| Component: | ui.dialog | Version: | 1.12.0 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Version 1.12.0 appears to break the icons setting for dialog buttons. Here's a jsFiddle https://jsfiddle.net/harpojaeger/hmanoLof/ showing that the setting has no effect (the rest of the dialog and, as far as I can tell, all the other settings, work fine). Downgrading the jQuery UI version from 1.12.0 to 1.11.4 (https://jsfiddle.net/harpojaeger/9vgyfe6v/1/) causes the icons to display as expected. See my Stack Overflow question on this topic for more details: http://stackoverflow.com/questions/38552143/jquery-ui-modal-dialog-button-icons-do-not-appear.
I'm a relative newbie at jQuery, but I'd be excited to try my hand at a patch if this bug can be verified.
Change History (4)
comment:1 follow-up: 3 Changed 7 years ago by
| Status: | new → open |
|---|
comment:2 Changed 7 years ago by
| Milestone: | none → 1.12.1 |
|---|---|
| Priority: | minor → blocker |
comment:3 Changed 7 years ago by
Replying to scottgonzalez:
Yup, dialog isn't passing through the deprecated options. This will be fixed, but you should updated your code. Please see http://jqueryui.com/upgrade-guide/1.12/#button
Excellent, thank you for the attention.
comment:4 Changed 7 years ago by
| Owner: | set to Scott González |
|---|---|
| Resolution: | → fixed |
| Status: | open → closed |
In 6c754b4:
Yup, dialog isn't passing through the deprecated options. This will be fixed, but you should updated your code. Please see http://jqueryui.com/upgrade-guide/1.12/#button
PR: https://github.com/jquery/jquery-ui/pull/1723