#15016 closed bug (fixed)

Opened July 24, 2016 10:18PM UTC

Closed July 25, 2016 12:39PM UTC

dialog: button icons settings have no effect

Reported by: harpojaeger Owned by: scottgonzalez
Priority: blocker Milestone: 1.12.1
Component: ui.dialog Version: 1.12.0
Keywords: Cc:
Blocked by: Blocking:
Description

Version 1.12.0 appears to break the icons setting for dialog buttons. Here's a jsFiddle https://jsfiddle.net/harpojaeger/hmanoLof/ showing that the setting has no effect (the rest of the dialog and, as far as I can tell, all the other settings, work fine). Downgrading the jQuery UI version from 1.12.0 to 1.11.4 (https://jsfiddle.net/harpojaeger/9vgyfe6v/1/) causes the icons to display as expected. See my Stack Overflow question on this topic for more details: http://stackoverflow.com/questions/38552143/jquery-ui-modal-dialog-button-icons-do-not-appear.

I'm a relative newbie at jQuery, but I'd be excited to try my hand at a patch if this bug can be verified.

Attachments (0)
Change History (4)

Changed July 25, 2016 12:21PM UTC by scottgonzalez comment:1

status: new → open

Yup, dialog isn't passing through the deprecated options. This will be fixed, but you should updated your code. Please see http://jqueryui.com/upgrade-guide/1.12/#button

PR: https://github.com/jquery/jquery-ui/pull/1723

Changed July 25, 2016 12:21PM UTC by scottgonzalez comment:2

milestone: none → 1.12.1
priority: minor → blocker

Changed July 25, 2016 12:23PM UTC by harpojaeger comment:3

Replying to [comment:1 scottgonzalez]:

Yup, dialog isn't passing through the deprecated options. This will be fixed, but you should updated your code. Please see http://jqueryui.com/upgrade-guide/1.12/#button PR: https://github.com/jquery/jquery-ui/pull/1723

Excellent, thank you for the attention.

Changed July 25, 2016 12:39PM UTC by scottgonzalez comment:4

owner: → scottgonzalez
resolution: → fixed
status: open → closed

In [changeset:"6c754b4b5b19a2a12eae68058458ef9ff7b72a0a" 6c754b4]:

#!CommitTicketReference repository="" revision="6c754b4b5b19a2a12eae68058458ef9ff7b72a0a"
Dialog: Support deprecated button options

Fixes #15016
Closes gh-1723