#15042 closed bug (fixed)

Opened September 05, 2016 06:26PM UTC

Closed September 14, 2016 04:06PM UTC

Sortable 'cancel' method raises js error "Uncaught TypeError: e.preventDefault is not a function"

Reported by:	rmacfadyen	Owned by:	scottgonzalez
Priority:	blocker	Milestone:	1.12.1
Component:	ui.sortable	Version:	1.12.0
Keywords:	regression	Cc:
Blocked by:		Blocking:

Description

The underlying problem is that the cancel method passes a fake event object to _mouseUp... but the fake event is just an object literal "{ target: null }" rather than an actual event. _mouseUp calls preventDefault on the passed event... which throws the error.

Here's a fiddle that reproduces the behavior: https://jsfiddle.net/rbsksys9/

Attachments (0)

Change History (3)

Changed September 14, 2016 01:36PM UTC by scottgonzalez comment:1

keywords:	→ regression
milestone:	none → 1.12.1
priority:	minor → blocker
status:	new → open

Caused by a1d69208bad175a27c7b50c27fdc10001563cd4d.

Changed September 14, 2016 01:44PM UTC by scottgonzalez comment:2

PR: https://github.com/jquery/jquery-ui/pull/1746

Changed September 14, 2016 04:06PM UTC by scottgonzalez comment:3

owner:	→ scottgonzalez
resolution:	→ fixed
status:	open → closed

In [changeset:"19027bb0852a8f26627ef5584e6dde77df9fd0df" 19027bb]:

#!CommitTicketReference repository="" revision="19027bb0852a8f26627ef5584e6dde77df9fd0df"
Sortable: Use an event object for simulated  in 

Regression caused by a1d69208bad175a27c7b50c27fdc10001563cd4d

Fixes #15042
Closes gh-1746