#15046 closed bug (fixed)

Draggable: Incorrectly forcing blur when clicking inside a draggable but outside the handle

Reported by: Scott González Owned by: Scott González
Priority: minor Milestone: 1.12.1
Component: ui.draggable Version: 1.12.0
Keywords: Cc:
Blocked by: Blocking:

Description

From https://github.com/jquery/jquery-ui/pull/1730

I was running into a problem with a popup menu control in a dialog; clicks weren't working (but keyboard was working fine). It turned out that the menu was getting destroyed before the click event could fire.

Tracked down the issue to the way draggable blurs focused controls; it was doing the blur before it ran through the logic to figure out if the drag was actually on the handle. I've moved the blur below these checks, so it'll only blur things if it actually needs to handle the drag. Otherwise, it asserts no opinion on what should and shouldn't be focused, which seems like the way things ought to be.

Change History (1)

comment:1 Changed 10 months ago by Scott González

Owner: set to Scott González
Resolution: fixed
Status: newclosed

In 8c66934:

Draggable: Fix spurious blur in dialogs on mousedown

I was running into a problem with a popup menu control in a dialog; clicks
weren't working (but keyboard was working fine). It turned out that the menu
was getting destroyed before the click event could fire.

Tracked down the issue to the way draggable blurs focused controls; it was
doing the blur before it ran through the logic to figure out if the drag was
actually on the handle. I've moved the blur below these checks, so it'll only
blur things if it actually needs to handle the drag. Otherwise, it asserts no
opinion on what should and shouldn't be focused, which seems like the way
things ought to be.

Also, added a unit test to check for the expected behavior.

Fixes #15046
Closes gh-1730

Note: See TracTickets for help on using tickets.