Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#15057 closed bug (notabug)

Dialog position flip doesn't work when pass coord manually

Reported by: Nickqwer Owned by: Nickqwer
Priority: minor Milestone: none
Component: ui.dialog Version: 1.12.1
Keywords: Cc:
Blocked by: Blocking:

Description

Dialog position flip doesn't work when I pass coordinates manually, but It works when it is an event. Here is the link. https://jsfiddle.net/38z9m9j9/

Change History (9)

comment:1 Changed 53 years ago by Nickqwer

Status: pendingnew

comment:1 Changed 6 years ago by Nickqwer

Forgot to say, that if you change the collision to 'flipfit flipfit' then it works.

comment:2 Changed 6 years ago by Jörn Zaefferer

Owner: set to Nickqwer
Status: newpending

Can you please explain what you're trying to achieve? Based on the fiddle, its not clear to me.

Here's a cleaned up fiddle, using the HTML and JS panels as intended: https://jsfiddle.net/9ds4c5yg/

comment:3 Changed 6 years ago by Nickqwer

Sorry for my late reply, I thought it would notify me by email if someone replied. So, in the example, I'm trying to open a dialog giving the coordinates of the right side of the screen, and I expect that it would flip the dialog horizontally without creating an x-scrollbar.

comment:4 Changed 6 years ago by Scott González

Resolution: notabug
Status: newclosed

With these positioning instructions, flipping will still not result in the dialog being more visible, so it won't flip. You should never use flip collision on a dialog anyway. Always use fit or flipfit (fit is likely your better option).

comment:5 Changed 6 years ago by Nickqwer

But then how about this scenario: https://jsfiddle.net/9ds4c5yg/2/ Here I've put an element, and used it as a target, and it has flipped, so there is no x-scrollbar anymore.

comment:6 Changed 6 years ago by Scott González

Because flipping in that case makes the dialog more visible than not flipping.

comment:7 Changed 6 years ago by Nickqwer

Exactly, and in the first scenario (https://jsfiddle.net/9ds4c5yg/), where I put the same coordinates manually, it should also be the case, but instead it is creating an x-scrollbar.

comment:8 Changed 6 years ago by Scott González

I don't think you understand how flipping works. Everything is flipped, including your offset. Notice in the second example that the meaning of left and right is inverted for both values. If you still need clarification, please use the forums, Stack Overflow, or IRC.

Note: See TracTickets for help on using tickets.