Skip to main content

Search and Top Navigation

#15057 closed bug (notabug)

Opened October 03, 2016 05:34AM UTC

Closed October 06, 2016 11:36AM UTC

Last modified October 07, 2016 12:37AM UTC

Dialog position flip doesn't work when pass coord manually

Reported by: Nickqwer Owned by: Nickqwer
Priority: minor Milestone: none
Component: ui.dialog Version: 1.12.1
Keywords: Cc:
Blocked by: Blocking:
Description

Dialog position flip doesn't work when I pass coordinates manually, but It works when it is an event.

Here is the link.

https://jsfiddle.net/38z9m9j9/

Attachments (0)
Change History (9)

Changed January 01, 1970 12:24AM UTC by Nickqwer comment:1

status: pendingnew

Changed October 03, 2016 05:36AM UTC by Nickqwer comment:2

Forgot to say, that if you change the collision to 'flipfit flipfit' then it works.

Changed October 03, 2016 12:59PM UTC by jzaefferer comment:3

owner: → Nickqwer
status: newpending

Can you please explain what you're trying to achieve? Based on the fiddle, its not clear to me.

Here's a cleaned up fiddle, using the HTML and JS panels as intended: https://jsfiddle.net/9ds4c5yg/

Changed October 06, 2016 06:44AM UTC by Nickqwer comment:4

Sorry for my late reply, I thought it would notify me by email if someone replied.

So, in the example, I'm trying to open a dialog giving the coordinates of the right side of the screen, and I expect that it would flip the dialog horizontally without creating an x-scrollbar.

Changed October 06, 2016 11:36AM UTC by scottgonzalez comment:5

resolution: → notabug
status: newclosed

With these positioning instructions, flipping will still not result in the dialog being more visible, so it won't flip. You should never use flip collision on a dialog anyway. Always use fit or flipfit (fit is likely your better option).

Changed October 06, 2016 06:02PM UTC by Nickqwer comment:6

But then how about this scenario: https://jsfiddle.net/9ds4c5yg/2/ Here I've put an element, and used it as a target, and it has flipped, so there is no x-scrollbar anymore.

Changed October 06, 2016 08:33PM UTC by scottgonzalez comment:7

Because flipping in that case makes the dialog more visible than not flipping.

Changed October 06, 2016 10:30PM UTC by Nickqwer comment:8

Exactly, and in the first scenario (https://jsfiddle.net/9ds4c5yg/), where I put the same coordinates manually, it should also be the case, but instead it is creating an x-scrollbar.

Changed October 07, 2016 12:37AM UTC by scottgonzalez comment:9

I don't think you understand how flipping works. Everything is flipped, including your offset. Notice in the second example that the meaning of left and right is inverted for both values. If you still need clarification, please use the forums, Stack Overflow, or IRC.