#15059 closed bug (fixed)

Opened October 04, 2016 07:49AM UTC

Closed October 04, 2016 03:30PM UTC

jQuery UI 1.12.1 Custom Theme Error

Reported by: knubew Owned by: arschmitz
Priority: blocker Milestone: 1.12.2
Component: ui.css-framework Version: 1.12.1
Keywords: Cc:
Blocked by: Blocking:
Description

I have updated my custom theme from 1.11.4 to 1.12.1. with this theme roller link:

http://jqueryui.com/themeroller/?ffDefault=Arial%2C%20Lucida%20Sans%2C%20sans-serif%2C%20Lucida%20Grande&fsDefault=0.9em&fwDefault=normal&cornerRadius=3px&bgColorHeader=e7eef3&bgTextureHeader=highlight_soft&borderColorHeader=b2c7d7&fcHeader=222222&iconColorHeader=72a7cf&bgColorContent=f9f9f9&bgTextureContent=highlight_hard&borderColorContent=dddddd&fcContent=362b36&iconColorContent=222222&bgColorDefault=e6e6e6&bgTextureDefault=glass&borderColorDefault=cccccc&fcDefault=444444&iconColorDefault=888888&bgColorHover=f0f0f0&bgTextureHover=glass&borderColorHover=b2c7d7&fcHover=0b5b98&iconColorHover=2694e8&bgColorActive=99c2ff&bgTextureActive=glass&borderColorActive=2694e8&fcActive=000000&iconColorActive=ffffff&bgColorHighlight=fbf5d0&bgTextureHighlight=glass&borderColorHighlight=f9dd34&fcHighlight=363636&iconColorHighlight=2e83ff&bgColorError=fef1ec&bgTextureError=glass&borderColorError=cd0a0a&fcError=cd0a0a&iconColorError=cd0a0a&bgColorOverlay=444444&bgTextureOverlay=diagonals_thick&bgImgOpacityOverlay=15&opacityOverlay=30&bgColorShadow=aaaaaa&bgTextureShadow=diagonals_small&bgImgOpacityShadow=0&opacityShadow=30&thicknessShadow=0px&offsetTopShadow=4px&offsetLeftShadow=4px&cornerRadiusShadow=4px&bgImgOpacityHeader=100&bgImgOpacityContent=100&bgImgOpacityDefault=80&bgImgOpacityHover=100&bgImgOpacityActive=50&bgImgOpacityHighlight=55&bgImgOpacityError=95&ctl=themeroller

but in the generated css file of the theme roller the following line is missing:

.ui-state-default .ui-icon{background-image:url("images/ui-icons_888888_256x240.png")}

I had to add this line by hand.

Attachments (0)
Change History (2)

Changed October 04, 2016 12:49PM UTC by scottgonzalez comment:1

milestone: none → 1.12.2
priority: minor → blocker
status: new → open

PR: https://github.com/jquery/jquery-ui/pull/1753

Changed October 04, 2016 03:30PM UTC by arschmitz comment:2

owner: → arschmitz
resolution: → fixed
status: open → closed

In [changeset:"1b0e947f46bc1261b15816f2dcbd239d83a86335" 1b0e947]:

#!CommitTicketReference repository="" revision="1b0e947f46bc1261b15816f2dcbd239d83a86335"
Theme: Removes css for ui-state-checked its not used any more

Also updates checkbox icon border color to go with background color
Ref jquery/download.jqueryui.com#335
Fixes #15059
Closes gh-1753