Skip to main content

Search and Top Navigation

#15089 closed bug (notabug)

Opened October 28, 2016 04:37PM UTC

Closed February 01, 2017 08:11PM UTC

bower distribution of jquery-ui does not include minified widgets

Reported by: ajssd Owned by:
Priority: minor Milestone: 1.12.2
Component: [meta] Version: 1.12.1
Keywords: Cc:
Blocked by: Blocking:

We download jquery-ui using bower, and we AMD 'require' it in using require.js. Roughly something like:

	paths: {
		'jquery-ui': 'bower_components/jquery-ui/ui',

And then we do something like

   require("jquery-ui/widgets/sortable" ...)

but that points to non-minified code. I would have expected to configure requirejs like this:

	paths: {
		'jquery-ui': 'bower_components/jquery-ui/ui/minified',

since there is a minified copy of all files like form.js, tabbable.js, etc. in the minified directory.

BUT the problem is there is no minified/widgets directory. All the files in the 'ui' directory (AND any sub-directories like widgets and effects) should ALSO be in the minified directory.

That way, requirejs can point to either jquery-ui/ui or jquery-ui/ui/minified and get the same set of files.

Attachments (0)
Change History (5)

Changed October 28, 2016 05:43PM UTC by scottgonzalez comment:1

resolution: → notabug
status: newclosed

You should be minifying on your own.

Changed October 28, 2016 07:06PM UTC by ajssd comment:2

I realize I can create a minified version of these files on my own, but that's not the answer here. It's clear that jquery-ui intentionally publishes minified versions of (almost) all its files, so the answer "you should be minifying on your own" doesn't make sense. There is a special 'minified' directory containing them. Same as most other software packages like jQuery, knockout, so on so on. The minified files are useful and easy to consume.

Question is -- why would jquery-ui publish SOME minified files but not all. By doing so, it makes it impossible to require in the 'widgets' because there is no 'minified/widgets' directory.

I really think this is just an oversight.

Can you please take a look at your scripts that publish to bower and include the minified versions of widgets?

Changed October 28, 2016 07:41PM UTC by scottgonzalez comment:3

resolution: notabug
status: closedreopened

Changed February 01, 2017 05:11PM UTC by scottgonzalez comment:4

milestone: none1.12.2
status: reopenedopen

Changed February 01, 2017 08:11PM UTC by scottgonzalez comment:5

resolution: → notabug
status: openclosed

When I tried to fix this, I realized it's impossible to fix because of my original point... You should be minifying on your own. We removed individual minified files from distributions a while ago.

Question is -- why would jquery-ui publish SOME minified files but not all.

That's a good question, but the answer is that *we* don't. The bower distributions are unofficial and maintained by the community. There is no published script for how that repo gets populated, so all I can do is point you to their bug tracker