Skip to main content

Search and Top Navigation

#15109 closed bug (fixed)

Opened December 01, 2016 10:22AM UTC

Closed May 02, 2017 07:11PM UTC

button: compatibility layer with checkboxradio breaking the prototype

Reported by: bago Owned by: arschmitz
Priority: blocker Milestone: 1.12.2
Component: ui.button Version: 1.12.1
Keywords: Cc:
Blocked by: Blocking:

Calling $('selector').button() on multiple mixed elements including both input-checkbox and simple a link doesn't work anymore with 1.12.

I created a simple jsbin to reproduce the issue:,js,console,output

Maybe the compatibility layer to call "checkboxradio" widget instead of the button widget leaves garbage in the button widget.

Attachments (0)
Change History (3)

Changed December 01, 2016 01:07PM UTC by arschmitz comment:1

owner: → arschmitz
status: newassigned

Hi thank you for reporting this. I can confirm the issue. The problem is the backcompat layer is only checking the first element when deciding which widget to call instead of looping over each. 2 side notes though. First backcompat layer will be removed in 1.13 and second the markup in your jsbin is not valid, an input cannot have content ( the label in your case ), but this is not causing the issue just wanted to mention.

Changed February 01, 2017 05:09PM UTC by scottgonzalez comment:2

milestone: none1.12.2
priority: minorblocker

Changed May 02, 2017 07:11PM UTC by scottgonzalez comment:3

resolution: → fixed
status: assignedclosed

In [changeset:"abc9e7ce2f3b60a18bf1f461c7cbfccb3fa02b53" abc9e7c]:

#!CommitTicketReference repository="" revision="abc9e7ce2f3b60a18bf1f461c7cbfccb3fa02b53"
Button: Fix backcompat when called on collection of mixed elements

Fixes #15109
Closes gh-1808