#15112 closed bug (fixed)

Opened December 07, 2016 02:04PM UTC

Closed October 14, 2020 10:02PM UTC

Last modified October 14, 2020 10:06PM UTC

update build system to use latest version of grunt

Reported by: pravi Owned by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
Priority: minor Milestone: none
Component: [meta] ui.build Version: 1.12.1
Keywords: Cc:
Blocked by: Blocking:
Description

We would like to build jquery ui in debian from the source repo. We already have grunt 1.0.1 in debian, but jquery-ui is using grunt 0.4.5. When we try to build jquery ui using grunt 1.0.1 , we get the following error,

$ grunt --verbose
Initializing
Command-line options: --verbose

Reading "Gruntfile.js" Gruntfile...OK

Registering Gruntfile tasks.
Loading "Gruntfile.js" tasks...ERROR
>> TypeError: grunt.util._.pluck is not a function
>>   at expandFiles (/home/pravi/forge/debian/git/pkg-javascript/jqueryui/Gruntfile.js:95:22)
>>   at Object.module.exports (/home/pravi/forge/debian/git/pkg-javascript/jqueryui/Gruntfile.js:21:13)
>>   at loadTask (/usr/lib/nodejs/grunt/lib/grunt/task.js:318:10)
>>   at Task.task.init (/usr/lib/nodejs/grunt/lib/grunt/task.js:437:5)
>>   at Object.grunt.tasks (/usr/lib/nodejs/grunt/lib/grunt.js:111:8)
>>   at Object.module.exports [as cli] (/usr/lib/nodejs/grunt/lib/grunt/cli.js:27:9)
>>   at Object.<anonymous> (/usr/lib/nodejs/grunt-cli/bin/grunt:49:20)
>>   at Module._compile (module.js:409:26)
>>   at Object.Module._extensions..js (module.js:416:10)
>>   at Module.load (module.js:343:32)
>>   at Function.Module._load (module.js:300:12)
>>   at Function.Module.runMain (module.js:441:10)
>>   at startup (node.js:139:18)
>>   at node.js:974:3

Please make it possible to build jquery-ui using grunt 1.0.1

Attachments (0)
Change History (4)

Changed December 07, 2016 02:12PM UTC by pravi comment:1

This seems to be related to version of lodash (debian has 4.16.6) https://github.com/gruntjs/grunt-contrib-clean/issues/90

Changed December 07, 2016 02:15PM UTC by rjollos comment:2

_comment0: The following patch fixes this error \ \ \ {{{ \ diff --git a/Gruntfile.js b/Gruntfile.js \ index be423b5..58a61ab 100644 \ --- a/Gruntfile.js \ +++ b/Gruntfile.js \ @@ -92,7 +92,7 @@ function mapMinFile( file ) { \ } \ \ function expandFiles( files ) { \ - return grunt.util._.pluck( grunt.file.expandMapping( files ), "src" ).map(function( values ) { \ + return grunt.util._.map( grunt.file.expandMapping( files ), "src" ).map(function( values ) { \ return values[ 0 ]; \ }); \ } \ @@ -129,7 +129,7 @@ function createBanner( files ) { \ "<%= pkg.homepage ? '* ' + pkg.homepage + '\\\\n' : '' %>" + \ (files ? "* Includes: " + fileNames.join(", ") + "\\n" : "") + \ "* Copyright <%= pkg.author.name %>;" + \ - " Licensed <%= _.pluck(pkg.licenses, 'type').join(', ') %> */\\n"; \ + " Licensed <%= _.map(pkg.licenses, 'type').join(', ') %> */\\n"; \ } \ \ grunt.initConfig({ \ \ }}} \ → 1481122262390315

The following patch fixes this error

diff --git a/Gruntfile.js b/Gruntfile.js
index be423b5..58a61ab 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -92,7 +92,7 @@ function mapMinFile( file ) {
 }
 
 function expandFiles( files ) {
-       return grunt.util._.pluck( grunt.file.expandMapping( files ), "src" ).map(function( values ) {
+       return grunt.util._.map( grunt.file.expandMapping( files ), "src" ).map(function( values ) {
                return values[ 0 ];
        });
 }
@@ -129,7 +129,7 @@ function createBanner( files ) {
                "<%= pkg.homepage ? '* ' + pkg.homepage + '\\\\n' : '' %>" +
                (files ? "* Includes: " + fileNames.join(", ") + "\\n" : "") +
                "* Copyright <%= pkg.author.name %>;" +
-               " Licensed <%= _.pluck(pkg.licenses, 'type').join(', ') %> */\\n";
+               " Licensed <%= _.map(pkg.licenses, 'type').join(', ') %> */\\n";
 }
 
 grunt.initConfig({

Changed October 14, 2020 10:02PM UTC by Michał Gołębiowski-Owczarek <m.goleb@gmail.com> comment:3

owner: → Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
resolution: → fixed
status: new → closed

In [changeset:"a22361dbe491c494a87f38600d9c1f91aa07d3e0" a22361d]:

#!CommitTicketReference repository="" revision="a22361dbe491c494a87f38600d9c1f91aa07d3e0"
Build: Update to the latest version of Grunt & many other packages

JSHint, JSCS & QUnit-related packages are not updated as they need more code
adjustments.

Fixes #15112
Closes gh-1882