#15157 closed bug (fixed)

Opened March 27, 2017 04:01PM UTC

Closed May 02, 2017 07:12PM UTC

Last modified May 02, 2017 07:12PM UTC

Can focus menu dividers with the keyboard

Reported by: klmcdorm Owned by: scottgonzalez
Priority: minor Milestone: 1.12.2
Component: ui.menu Version: 1.12.1
Keywords: Cc:
Blocked by: Blocking:
Description

jsFiddle:[https://jsfiddle.net/bmu3k2w3/2/]

If a menu has a divider as the first or last item, it can be focused using the keyboard.

Reproduction steps:

1. Click on the input box and press Tab to focus on the menu.

2. Move focus to the last menu item by pressing the down arrow key.

3. Try to move focus back to the first menu item by pressing down again.

4. Focus moves to the divider before the first item instead. In the menu's focus event, ui.item is the divider.

This also happens when moving up from the first item, or when using Page Up or Page Down.

Tested on Windows 7 with Chrome 56.0.2924.87, Firefox 52.0.1, and Internet Explorer 11.0.9600.18537.

Attachments (0)
Change History (4)

Changed April 17, 2017 04:28PM UTC by scottgonzalez comment:1

https://github.com/jquery/jquery-ui/pull/1804

Changed April 17, 2017 04:28PM UTC by scottgonzalez comment:2

status: new → open

Changed May 02, 2017 07:12PM UTC by scottgonzalez comment:3

owner: → scottgonzalez
resolution: → fixed
status: open → closed

In [changeset:"a3e953b495905d0c67790e65032841451b470ce1" a3e953b]:

#!CommitTicketReference repository="" revision="a3e953b495905d0c67790e65032841451b470ce1"
Menu: Don't focus dividers when wrapping via keyboard navigation

Fixes #15157
Closes gh-1804

Changed May 02, 2017 07:12PM UTC by scottgonzalez comment:4

milestone: none → 1.12.2