Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#15165 closed feature (fixed)

Create _scroll extension point in sortable

Reported by: A. Wells Owned by: Scott González
Priority: minor Milestone: 1.12.2
Component: ui.sortable Version: 1.12.1
Keywords: Cc:
Blocked by: Blocking:

Description

The ability to extend scroll based functionality in ui.sortable would be facilitated by moving the current scroll code in _mouseDrag to an extension point (such as _scroll).

Such an extension point would render the code more readable and manageable and provide the ability to check for scrolling in non native scrollable areas. As an example: ​https://github.com/borgboyone/jQuery-UI-ScrollPane/

Change History (2)

comment:1 Changed 6 years ago by Scott González

Owner: set to Scott González
Resolution: → fixed
Status: new → closed

In c866e45:

Sortable: Fix various scrolling issues

  • Created _scroll extension point and migrated scroll code from _mouseDrag
  • Cleaned up logic for scrolled
  • Fixed appendTo functionality to match documentation
  • Remove unnecessary function calls
  • Move set-up position functions to appropriate place
  • Base scrollParent on placeholder and not helper
  • Update scrollParent when switching containers

Fixes #3173
Fixes #15165
Fixes #15166
Fixes #15167
Fixes #15168
Fixes #15169
Fixes #15170
Closes gh-1793

comment:2 Changed 6 years ago by Scott González

Milestone: none → 1.12.2
Note: See TracTickets for help on using tickets.