#15168 closed bug (fixed)

Opened April 18, 2017 01:56AM UTC

Closed May 02, 2017 06:03PM UTC

Last modified May 02, 2017 07:09PM UTC

Incorrect ScrollParent is chosen when helper is not a child of the active container

Reported by: borgboyone Owned by: scottgonzalez
Priority: minor Milestone: 1.12.2
Component: ui.sortable Version: 1.12.1
Keywords: Cc:
Blocked by: Blocking:
Description

The scroll parent should be taken from the placeholder and not the helper since the helper may not be a DOM child of the active container. This is mostly in reference to the appendTo option but also applies to connecting container traversal.

Attachments (0)
Change History (2)

Changed May 02, 2017 06:03PM UTC by scottgonzalez comment:1

owner: → scottgonzalez
resolution: → fixed
status: new → closed

In [changeset:"c866e455373028a62a0956455a229fef63e91fac" c866e45]:

#!CommitTicketReference repository="" revision="c866e455373028a62a0956455a229fef63e91fac"
Sortable: Fix various scrolling issues

* Created _scroll extension point and migrated scroll code from _mouseDrag
* Cleaned up logic for scrolled
* Fixed appendTo functionality to match documentation
* Remove unnecessary function calls
* Move set-up position functions to appropriate place
* Base scrollParent on placeholder and not helper
* Update scrollParent when switching containers

Fixes #3173
Fixes #15165
Fixes #15166
Fixes #15167
Fixes #15168
Fixes #15169
Fixes #15170
Closes gh-1793

Changed May 02, 2017 07:09PM UTC by scottgonzalez comment:2

milestone: none → 1.12.2