Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#15168 closed bug (fixed)

Incorrect ScrollParent is chosen when helper is not a child of the active container

Reported by: A. Wells Owned by: Scott González
Priority: minor Milestone: 1.12.2
Component: ui.sortable Version: 1.12.1
Keywords: Cc:
Blocked by: Blocking:

Description

The scroll parent should be taken from the placeholder and not the helper since the helper may not be a DOM child of the active container. This is mostly in reference to the appendTo option but also applies to connecting container traversal.

Change History (2)

comment:1 Changed 6 years ago by Scott González

Owner: set to Scott González
Resolution: → fixed
Status: new → closed

In c866e45:

Sortable: Fix various scrolling issues

  • Created _scroll extension point and migrated scroll code from _mouseDrag
  • Cleaned up logic for scrolled
  • Fixed appendTo functionality to match documentation
  • Remove unnecessary function calls
  • Move set-up position functions to appropriate place
  • Base scrollParent on placeholder and not helper
  • Update scrollParent when switching containers

Fixes #3173
Fixes #15165
Fixes #15166
Fixes #15167
Fixes #15168
Fixes #15169
Fixes #15170
Closes gh-1793

comment:2 Changed 6 years ago by Scott González

Milestone: none → 1.12.2
Note: See TracTickets for help on using tickets.