Opened 5 years ago
#15272 new bug
Easing demo broken with jQuery 1.12, 2.2, 3.0
| Reported by: | Joel Davies | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | none |
| Component: | ui.effects.* (individual effect) | Version: | 1.12.1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
The Easing demo doesn't work with jQuery 1.12, 2.2, or 3.0+ (at least in Firefox 58/Chrome 64). Only the default jQuery easing values are shown - none of the additions in jQuery UI are visible. This affects the current documentation on both jqueryui.com and api.jqueryui.com but I have reported here because the problem is the demo itself.
The change was introduced by the new value jQuery.easing._default in jQuery commit 5f2ea40, which returns the string "swing" instead of a function. The problem is that Line 74 in the demo directly executes the value impl, without checking to see if it is a function. At this point, the script crashes both in FF and Chrome.
I can see two ways to fix it. Either check specifically for "_default" and exclude it or check to make sure impl is a function.
jsFiddle examples (these all use jQuery 1.12.1 which is the version currently used for the demo on jqueryui.com)
- current code (not working)
- specifically check for _default (working)
- check if impl is a function (working)
The only change I made in the latter two is line 11.