#1716 closed bug (fixed)
Resizable helper is added to this.options.modifyThese on every drag-start.
Reported by: | c_t | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 1.5 |
Component: | ui.core | Version: | 1.2.1 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
I just realized that the resize-helper is added to the this.options.modifyThese array on every drag-start. I think from the performance point of view that's not good since the drag-function loops through this array and re-sets css-properties on drag. I see no use of setting the css property of the helper multiple times... Furthermore performance decreases with every additional resize...
My solution is to replace
this.options.modifyThese.push([$(this.helper),0,0]);
with
if ( this.options.modifyThese.length == 0 || !this.options.modifyThese[this.options.modifyThese.length-1][0].is('.ui-resizable') ) { this.options.modifyThese.push([$(this.helper),0,0]); }
in ui.resizables.js in the start-method.
Change History (3)
comment:1 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 14 years ago by
Milestone: | → 1.5 |
---|
Note: See
TracTickets for help on using
tickets.
D'oh! Thanks for finding this. Fixed!