Skip to main content

Search and Top Navigation

#1716 closed bug (fixed)

Opened September 23, 2007 12:25PM UTC

Closed September 23, 2007 01:56PM UTC

Last modified February 26, 2009 11:10AM UTC

Resizable helper is added to this.options.modifyThese on every drag-start.

Reported by: c_t Owned by:
Priority: major Milestone: 1.5
Component: ui.core Version: 1.2.1
Keywords: Cc:
Blocked by: Blocking:
Description

I just realized that the resize-helper is added to the this.options.modifyThese array on every drag-start. I think from the performance point of view that's not good since the drag-function loops through this array and re-sets css-properties on drag. I see no use of setting the css property of the helper multiple times... Furthermore performance decreases with every additional resize...

My solution is to replace

		this.options.modifyThese.push([$(this.helper),0,0]);

with

			if ( this.options.modifyThese.length == 0 || !this.options.modifyThese[this.options.modifyThese.length-1][0].is('.ui-resizable') ) {
				this.options.modifyThese.push([$(this.helper),0,0]);
			}

in ui.resizables.js in the start-method.

Attachments (0)
Change History (3)

Changed September 23, 2007 01:56PM UTC by paul comment:1

resolution: → fixed
status: newclosed

D'oh! Thanks for finding this. Fixed!

Changed May 24, 2008 03:39AM UTC by comment:2

milestone: 1.2.2

Milestone 1.2.2 deleted

Changed February 26, 2009 11:10AM UTC by paul comment:3

milestone: → 1.5