Skip to main content

Search and Top Navigation

#1845 closed bug (fixed)

Opened October 25, 2007 11:41PM UTC

Closed November 25, 2007 01:39AM UTC

Last modified February 26, 2009 11:03AM UTC

Tabs - Openning multiple AJAX tabs causes spinner to not be removed

Reported by: hiro Owned by: klaus
Priority: minor Milestone: 1.5
Component: ui.core Version: 1.2.1
Keywords: tabs Cc:
Blocked by: Blocking:
Description

Using Tabs 3 which can be seen demoed on the test page:

http://stilbuero.de/jquery/tabs_3/

Under "Ajax tabs"

Click tab Two then click tab Three very quickly before tab two finishes loading. Notice how the Loading... spinner dialog doesn't not get updated with the proper text? The spinner logo is removed on all tabs, but tab Two remains with the spinner text.

This appears to be caused around line 449 of ui.tabs.js by $span not being a direct pointer to each tab, but of the last one?

I believe I have a somewhat crude fix for this:

from line 442:

// load

if (o.spinner) {

$span.attr('text', $span.html());

$span.html('<em>' + o.spinner + '</em>');

}

setTimeout(function() {

$(a.hash).load(url, function() {

if (o.spinner) {

tab_contents_id = "a[href='#"+a.href.split('#')[1]+"'] span";

$(tab_contents_id).html($(tab_contents_id).attr('text'));

}

$a.removeClass(o.loadingClass);

...

This seems to solve the problem with my test case...

Attachments (0)
Change History (4)

Changed November 05, 2007 03:40PM UTC by paul comment:1

owner: → klaus

Changed November 25, 2007 01:39AM UTC by klaus comment:2

resolution: → fixed
status: newclosed

r3922

Changed May 24, 2008 03:39AM UTC by comment:3

milestone: 1.2.2

Milestone 1.2.2 deleted

Changed February 26, 2009 11:03AM UTC by paul comment:4

milestone: → 1.5