Opened 13 years ago

Closed 13 years ago

Last modified 11 years ago

#1921 closed bug (fixed)

[PATCH] function outerHeight(el) from ui.mouse.js calculates "width"

Reported by: ptab Owned by:
Priority: critical Milestone: 1.5
Component: ui.core Version: 1.2.1
Keywords: outerHeight Cc:
Blocked by: Blocking:

Description

File: ui.mouse.js

Look at the second line of the code: WIDTH !!! should be HEIGHT. It makes Drag&Drop module not working (tolerance):

function outerHeight(el) {

var $el = $(el), oh = $el.width(); for (var i = 0, props = ['borderTopWidth', 'paddingTop', 'paddingBottom', 'borderBottomWidth']; i < props.length; i++)

oh += num($el, props[i]);

return oh;

}

Attachments (1)

patch_ticket_1921.diff (500 bytes) - added by ptab 13 years ago.
PATCH

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by ptab

Attachment: patch_ticket_1921.diff added

PATCH

comment:1 Changed 13 years ago by brandon

Resolution: fixed
Status: newclosed

Fixed in Rev [3826].

I just used the dimensions outerWidth and outerHeight methods which were just updated for a boost in performance.

comment:2 Changed 12 years ago by (none)

Milestone: 1.2.2

Milestone 1.2.2 deleted

comment:3 Changed 11 years ago by paul

Milestone: 1.5
Note: See TracTickets for help on using tickets.