Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#1997 closed bug (worksforme)

Dialog position relative to page length and not window height.

Reported by: Xichekolas Owned by: rdworth
Priority: major Milestone:
Component: ui.core Version: 1.2.1
Keywords: ui, dialog, position Cc:
Blocked by: Blocking:

Description

In ui.dialog.js, several of the position options (lines 113-134) determine the top offset of the dialog based on math involving $(window).height(). This is the actual length of the page, not the height of the viewable area of the page.

The result is that on really long pages, this value is huge and the dialog is opened way below where the user is currently viewing. It seems like the open fails, but you just have to scroll down quite a bit to find it. Is there a way to get the height of the viewable area rather than what amounts to the length of the entire page?

Change History (3)

comment:1 Changed 11 years ago by rdworth

Owner: set to rworth
Status: newassigned

comment:2 Changed 11 years ago by rdworth

Resolution: worksforme
Status: assignedclosed

$(window).height() is correct here. You must be thinking of $(document).height(). Tested latest (rev4061) in IE and FF. Worksforme.

comment:3 Changed 11 years ago by (none)

Milestone: 1.2.2

Milestone 1.2.2 deleted

Note: See TracTickets for help on using tickets.