Skip to main content

Search and Top Navigation

#1997 closed bug (worksforme)

Opened December 03, 2007 04:31AM UTC

Closed December 07, 2007 01:26AM UTC

Last modified May 24, 2008 03:39AM UTC

Dialog position relative to page length and not window height.

Reported by: Xichekolas Owned by: rdworth
Priority: major Milestone:
Component: ui.core Version: 1.2.1
Keywords: ui, dialog, position Cc:
Blocked by: Blocking:

In ui.dialog.js, several of the position options (lines 113-134) determine the top offset of the dialog based on math involving $(window).height(). This is the actual length of the page, not the height of the viewable area of the page.

The result is that on really long pages, this value is huge and the dialog is opened way below where the user is currently viewing. It seems like the open fails, but you just have to scroll down quite a bit to find it. Is there a way to get the height of the viewable area rather than what amounts to the length of the entire page?

Attachments (0)
Change History (3)

Changed December 04, 2007 11:24AM UTC by rdworth comment:1

owner: → rworth
status: newassigned

Changed December 07, 2007 01:26AM UTC by rdworth comment:2

resolution: → worksforme
status: assignedclosed

$(window).height() is correct here. You must be thinking of $(document).height(). Tested latest (rev4061) in IE and FF. Worksforme.

Changed May 24, 2008 03:39AM UTC by comment:3

milestone: 1.2.2

Milestone 1.2.2 deleted