Opened 16 years ago

Closed 16 years ago

Last modified 14 years ago

#2008 closed bug (fixed)

[PATCH] Open and Close Multiple Dialogs

Reported by: Xichekolas Owned by: rdworth
Priority: major Milestone: 1.5
Component: ui.core Version: 1.2.1
Keywords: ui dialog open close Cc:
Blocked by: Blocking:


Two problems:

  1. All dialogs were opening with the same data. This made all the close buttons only close the most recently opened dialog. Fixed this by adding the 'new' keyword before the call to $.ui.dialogInit
  1. Closing a dialog only sets it to display:none. However, reopening the dialog actually creates a whole duplicate dialog, rather than unhiding the existing one. This is because the if statement that checked to see if the div on which we call .dialog() is already a dialog was checking for the wrong css class (due to the way the dialog is built, the original div gets the .ui-dialog-content class, not the .ui-dialog class.

Attachments (1)

ReopenPatch.diff (423 bytes) - added by Xichekolas 16 years ago.

Download all attachments as: .zip

Change History (6)

Changed 16 years ago by Xichekolas

Attachment: ReopenPatch.diff added

comment:1 Changed 16 years ago by davidserduke

Component: coreui

comment:2 Changed 16 years ago by rdworth

Owner: set to rworth
Status: newassigned

comment:3 Changed 16 years ago by rdworth

Resolution: fixed
Status: assignedclosed

Thanks for the patch. Fixed in rev4075.

comment:4 Changed 15 years ago by (none)

Milestone: 1.2.2

Milestone 1.2.2 deleted

comment:5 Changed 14 years ago by paul

Milestone: 1.5
Note: See TracTickets for help on using tickets.