Opened 9 years ago

Closed 6 years ago

#2358 closed enhancement (fixed)

ui dialog show and hide overrides

Reported by: mnichols Owned by: scottgonzalez
Priority: major Milestone: 1.8.4
Component: ui.dialog Version: 1.5
Keywords: dialog show hide open close Cc:
Blocked by: Blocking:

Description

There is no way to control the behaviour of the show() and hide() calls on ui dialog. Therefore applying effects to the dialog is impossible, making the dialog presentation...bland. This patch adds 'show' and 'hide' options accepting the uiDialog object to uiDialog.show() and uiDialog.hide() respectively. This lets the dev in the options do (using fx): show: function(dialog){ $j(dialog).show('drop',{ direction: 'down',duration:1500 }); }, hide: function(dialog){ $j(dialog).hide('drop',{ direction: 'down',duration:800 }); }

Change History (17)

comment:1 Changed 9 years ago by paul

  • Owner changed from paul to rworth

comment:2 Changed 9 years ago by rdworth

  • Status changed from new to assigned

comment:3 Changed 8 years ago by anonymous

  • Milestone 1.2.4 deleted

Milestone 1.2.4 deleted

comment:4 Changed 8 years ago by paul

  • Component changed from ui.core to ui.dialog
  • Version changed from 1.2.3 to 1.5b4

comment:5 Changed 8 years ago by rdworth

  • Keywords open close added
  • Status changed from assigned to accepted

comment:6 Changed 8 years ago by rdworth

  • Milestone set to 1.5.1

partial fix in [255]. Still need to add support for options and/or callback handler

comment:7 Changed 8 years ago by rdworth

  • Version changed from 1.5b4 to 1.5

comment:8 Changed 8 years ago by paul

  • Milestone changed from 1.5.1 to 1.5.2

comment:9 Changed 8 years ago by Cloudream

new patch:

if you want to use effects, set show: { effect:"xxx", options:{}, speed:yyy }

also work with original show parameters, like show:500 or show:"normal"

comment:10 Changed 8 years ago by Cloudream

what about add a 'toggle' method to open/close dialogs?

comment:11 Changed 8 years ago by paul

  • Milestone changed from 1.5.2 to 1.6b

comment:12 Changed 8 years ago by Cloudream

  • Milestone changed from 1.6b to 1.7

comment:13 Changed 8 years ago by Cloudream

  • Milestone changed from 1.7 to 1.6

comment:14 Changed 8 years ago by jzaefferer

  • Milestone changed from 1.6 to 1.7

Deferred to 1.7, will need docs updates.

comment:15 Changed 7 years ago by scottgonzalez

  • Milestone changed from 1.next to 1.8
  • Owner changed from rdworth to scott.gonzalez

Added patch to modify how show/hide/toggle works to allow specifying the effect name in the options hash. This simplifies the work needed inside individual widgets to support effects. I also created a patch that allows specifying the callback separately even when the options hash defines the effect. This makes it easy for widgets to expose options for effects while still providing the plugin's own callback. For example, dialog triggers the close callback after the hide effect completes and being able to specify the callback as the second parameter (and override any callback specified in the options hash) is much easier than having to override the callback if it exists. I think it's fine to not allow specifying a callback in the effects option because there is almost always going to be an event/callback that gets triggered by the plugin at the same time.

comment:17 Changed 6 years ago by scottgonzalez

  • Milestone changed from 1.9 to 1.8.4
  • Resolution set to fixed
  • Status changed from accepted to closed

We got this working at some point... http://jsbin.com/obuza3/edit

Note: See TracTickets for help on using tickets.