#2513 closed enhancement (fixed)
Accordion: classNames should be default
Reported by: | neojp | Owned by: | joern |
---|---|---|---|
Priority: | trivial | Milestone: | |
Component: | ui.accordion | Version: | 1.5 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
Theme related classNames should be added to the accordions by default.
$(container).addClass("ui-accordion-container ui-accordion");
// add classNames and spans to header options.headers.addClass('ui-accordion-link').prepend('<span class="ui-accordion-left"></span>').append('<span class="ui-accordion-right"></span>');
Attachments (2)
Change History (11)
Changed 15 years ago by
Attachment: | ui.accordion_theme.diff added |
---|
comment:1 Changed 15 years ago by
Talking about a theming issue, headers should be relative positioned.
ul.ui-accordion-container li a.ui-accordion-link { position: relative }
Changed 15 years ago by
Attachment: | flora.accordion.diff added |
---|
accordion flora theme, position relative added to headers
comment:2 Changed 15 years ago by
Owner: | changed from paul to joern |
---|
comment:3 Changed 15 years ago by
comment:4 Changed 15 years ago by
postion:relative; is not that necessary if you don't append the header spans. If they are not positioned inside a reltive they will appear on the top right corner of the document.
Regarding this,
$(container).addClass("ui-accordion-container ui-accordion");
I'm not sure why the accordion plugin uses 2 different classNames for the same element, since it never uses one. I think we could get rid of one and change the css styles to match the className choosen.
comment:5 Changed 15 years ago by
Component: | ui.core → ui.accordion |
---|---|
Version: | → 1.5b4 |
comment:6 Changed 15 years ago by
Version: | 1.5b4 → 1.5 |
---|
comment:7 Changed 14 years ago by
Milestone: | → TDB |
---|
Note: See
TracTickets for help on using
tickets.
UI Accordion: add classnames, and spans for themes