Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#2525 closed enhancement (fixed)

Standardised way to pass coordinates to plugins.

Reported by: xover Owned by: Scott González
Priority: major Milestone: 1.8
Component: [meta] ui.dev Version: 1.5b4
Keywords: Cc:
Blocked by: Blocking:

Description

Looking at Draggable's cursorAt and Dialog's position options I note that they use different ways to pass a set of coordinates to the function. Dialog uses an array of offsets from top left, where Draggable uses a hash of either {top: n, left: m} or {bottom: n, right: m} (etc.).

There should probably be a common way to pass coordinates to plugins; possibly by making Draggable's way the default with Dialog's way as a convenience shortcut. Dialog's method can also be extended to allow negative offsets to be relative to the bottom and right edges.

Change History (15)

comment:1 Changed 9 years ago by rdworth

I recommend that both could accept either an array [x, y] or a hash {top, bottom, left, right}

comment:2 Changed 9 years ago by paul

Owner: changed from paul to rworth

Draggables is updated to also take an array now Could you please continue with dialog?

comment:3 Changed 9 years ago by paul

Priority: majorminor

To make it easier to update the values later on internal API wise, I suggest to use hashes only.

comment:4 Changed 9 years ago by paul

Type: bugenhancement

comment:5 Changed 9 years ago by paul

Version: 1.5b4

comment:6 Changed 9 years ago by Cloudream

Component: ui.coreui.dialog
Milestone: 1.6
Owner: changed from rdworth to rworth
Status: newassigned

comment:7 Changed 9 years ago by Cloudream

Owner: changed from rworth to rdworth

comment:8 Changed 9 years ago by Scott González

Milestone: 1.61.7

comment:9 Changed 8 years ago by Scott González

Component: ui.dialog[meta] ui.dev
Milestone: 1.next1.8
Owner: rdworth deleted
Priority: minormajor

comment:10 Changed 8 years ago by Scott González

requires positionTo plugin

comment:11 Changed 8 years ago by Scott González

Position options:
Dialog - position
Draggable - cursorAt
Sortable - cursorAt

comment:12 Changed 8 years ago by Scott González

Owner: set to scott.gonzalez

comment:13 Changed 8 years ago by Scott González

Fixed draggable in r3021.

comment:14 Changed 8 years ago by Scott González

Fixed sortable in r3022.

comment:15 Changed 8 years ago by Scott González

Resolution: fixed
Status: assignedclosed

Fixed dialog in r3024.

Note: See TracTickets for help on using tickets.