Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#2591 closed bug (fixed)

Slider size method only returns the width of the slider

Reported by: natecavanaugh Owned by: joern
Priority: major Milestone: 1.5
Component: ui.core Version: 1.2.3
Keywords: Cc:
Blocked by: Blocking:

Description

When checking for a sliders size, the size method only returns it's outerWidth, however, when using a vertical slider, you need the height of the slider, not its width.

The fix is to change this on line 192 in ui.slider.js:

return this.actualSize
(this.actualSize = this.element.outerWidth());

to this:

return this.actualSize
(this.actualSize = (this.options.axis == 'horizontal') ? this.element.outerWidth() : this.element.outerHeight());

Change History (5)

comment:1 Changed 12 years ago by natecavanaugh

Somehow the pipes are missing:

return this.actualSize | | (this.actualSize = (this.options.axis == 'horizontal') ? this.element.outerWidth() : this.element.outerHeight());

comment:2 Changed 12 years ago by paul

Owner: changed from paul to joern

comment:3 Changed 12 years ago by joern

Resolution: fixed
Status: newclosed

That got fixed some time ago, see latest revision.

comment:4 Changed 12 years ago by (none)

Milestone: 1.2.4

Milestone 1.2.4 deleted

comment:5 Changed 11 years ago by paul

Milestone: 1.5
Note: See TracTickets for help on using tickets.