Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#2804 closed bug (fixed)

[ui dialog] Showing a modal dialog on a radio button select in IE (7 and 8) bug

Reported by: srepciuc Owned by: Scott González
Priority: major Milestone:
Component: ui.dialog Version: 1.2.3
Keywords: ui radio button Cc:
Blocked by: Blocking:

Description

I wanted to reproduce this bug with the latest version of jQuery ui but both 1.5b3 and 1.5b4 fail to work at all in IE for me.

I have two radio buttons on a page. When I select one of them, I want a dialog to appear. I set it to be modal. In IE both 6 and 7, when I click the radio button, the dialog is displayed, but the checked status of the radio buttons is lost. I saw there were some similar bugs in the past.

Attachments (1)

bug.html (1.5 KB) - added by srepciuc 12 years ago.
The bug shows only when modal is set to true

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by srepciuc

Attachment: bug.html added

The bug shows only when modal is set to true

comment:1 Changed 12 years ago by Scott González

Owner: changed from paul to scott.gonzalez
Status: newassigned

comment:2 Changed 12 years ago by Scott González

Resolution: fixed
Status: assignedclosed

Fixed in [5582].

comment:3 Changed 12 years ago by (none)

Milestone: 1.2.4

Milestone 1.2.4 deleted

comment:4 Changed 11 years ago by merbjedi

The fix for this ticket needs to be reconsidered and either fixed for performance, or reverted. The cure is worse than the disease.

This line causes massive slowdowns on any page of moderate to large size: $('a, :input').add([document, window]).unbind('.dialog-overlay');

The binding of all the dialog-overlay events is fast, but unbinding them all is a huge slowdown. You'll encounter it when you fire off the close event of a dialog, which fires the overlay.destroy().

comment:5 Changed 11 years ago by merbjedi

Just to clarify, I'm refering to ui.dialog.js. Lines 557-578, and Lines 605-607. These are marked as being a fix for this issue (2804)

comment:6 Changed 11 years ago by paul

Component: ui.coreui.dialog
Note: See TracTickets for help on using tickets.