Dynamic adding of a remote tab causes error

[sjmittal]

Hi, When I add a tab dynamically whose contents are to be pulled from a remote location specified by the url it causes and error. The problem is that it treats the url as callback function. In the add function following code:

if (href)

this.load(index, href);

if to be replaced by

if (href)

this.load(index);

to fix this problem.

If fix is found appropriate please include this is code.

Thanks Sachin

[mdalessio]

I encountered this issue as well, which only occurs for me when trying to invoke tabs() on an empty UL.

In addition to the change made above, one other change is necessary to avoid access non-existent $.data. Full patch is attached.

[mdalessio]

Submitted patch

[mdalessio]

To reproduce this issue:

1. invoke tabs() on an empty UL
2. dynamically add, via tabs('add',...) a remote (Ajax) URL

And again, the above patch allows me to do this with no js errors.

[(none)]

Milestone 1.2.4 deleted

[Scott González]

I can't reproduce this problem.

mdalessio: I think instantiating tabs on an empty list is invalid. Tabs always have a exactly one panel showing. If you have an empty list, that's not possible. If you strongly disagree with this, please create a new ticket and the UI team can reconsider this.