#2839 closed bug (worksforme)

Opened May 10, 2008 01:47PM UTC

Closed May 30, 2008 07:51AM UTC

Last modified May 16, 2010 03:24PM UTC

Dynamic adding of a remote tab causes error

Reported by: sjmittal Owned by: klaus
Priority: major Milestone:
Component: ui.tabs Version: 1.5b4
Keywords: ui.tabs Cc:
Blocked by: Blocking:
Description

Hi,

When I add a tab dynamically whose contents are to be pulled from a remote location specified by the url it causes and error.

The problem is that it treats the url as callback function.

In the add function following code:

if (href)

this.load(index, href);

if to be replaced by

if (href)

this.load(index);

to fix this problem.

If fix is found appropriate please include this is code.

Thanks

Sachin

Attachments (0)
Change History (6)

Changed May 11, 2008 12:57PM UTC by paul comment:1

owner: paul → klaus

Changed May 14, 2008 03:39PM UTC by mdalessio comment:2

I encountered this issue as well, which only occurs for me when trying to invoke tabs() on an empty UL.

In addition to the change made above, one other change is necessary to avoid access non-existent $.data. Full patch is attached.

Changed May 14, 2008 03:42PM UTC by mdalessio comment:3

To reproduce this issue:

1. invoke tabs() on an empty UL

2. dynamically add, via tabs('add',...) a remote (Ajax) URL

And again, the above patch allows me to do this with no js errors.

Changed May 24, 2008 03:39AM UTC by comment:4

milestone: 1.2.4

Milestone 1.2.4 deleted

Changed May 24, 2008 03:48AM UTC by paul comment:5

component: ui.core → ui.tabs
version: 1.2.3 → 1.5b4

Changed May 30, 2008 07:51AM UTC by scottgonzalez comment:6

resolution: → worksforme
status: new → closed

I can't reproduce this problem.

mdalessio: I think instantiating tabs on an empty list is invalid. Tabs always have a exactly one panel showing. If you have an empty list, that's not possible. If you strongly disagree with this, please create a new ticket and the UI team can reconsider this.