Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#2857 closed bug (fixed)

[ui.dialog] Exceptions thrown if positioning in iframe

Reported by: tyler Owned by: paul
Priority: critical Milestone: 1.5
Component: ui.core Version: 1.2.3
Keywords: Cc:
Blocked by: Blocking:

Description

If you're in a less-than-stellar browser (Safari 2, IE6) that has certain security restraints on trying to set the position of "top" from inside a frame (besides it being an object) currently dialog.position() will thrown an exception that will break the entire page.

The attached patch will safely set "top" in Firefox and such, and have certain fallback behavior for browsers that have issues with iframes trying set "top".

Attachments (1)

ui.dialog.js.patch (2.2 KB) - added by tyler 12 years ago.
this one's for real

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by tyler

Attachment: ui.dialog.js.patch added

this one's for real

comment:1 Changed 12 years ago by tyler

Ugh, talk about overengineering, the biggest problem is that it's reassigning the top variable >_<

comment:2 Changed 12 years ago by Scott González

Resolution: fixed
Status: newclosed

Fixed in [5595]. Thanks.

comment:3 Changed 12 years ago by (none)

Milestone: 1.2.4

Milestone 1.2.4 deleted

comment:4 Changed 11 years ago by paul

Milestone: 1.5
Note: See TracTickets for help on using tickets.