Skip to main content

Search and Top Navigation

#2857 closed bug (fixed)

Opened May 13, 2008 08:52PM UTC

Closed May 14, 2008 04:43PM UTC

Last modified February 26, 2009 12:07PM UTC

[ui.dialog] Exceptions thrown if positioning in iframe

Reported by: tyler Owned by: paul
Priority: critical Milestone: 1.5
Component: ui.core Version: 1.2.3
Keywords: Cc:
Blocked by: Blocking:

If you're in a less-than-stellar browser (Safari 2, IE6) that has certain security restraints on trying to set the position of "top" from inside a frame (besides it being an object) currently dialog.position() will thrown an exception that will break the entire page.

The attached patch will safely set "top" in Firefox and such, and have certain fallback behavior for browsers that have issues with iframes trying set "top".

Attachments (0)
Change History (4)

Changed May 14, 2008 02:14AM UTC by tyler comment:1

Ugh, talk about overengineering, the biggest problem is that it's reassigning the top variable >_<

Changed May 14, 2008 04:43PM UTC by scottgonzalez comment:2

resolution: → fixed
status: newclosed

Fixed in [5595]. Thanks.

Changed May 24, 2008 03:39AM UTC by comment:3

milestone: 1.2.4

Milestone 1.2.4 deleted

Changed February 26, 2009 12:07PM UTC by paul comment:4

milestone: → 1.5