#3038 closed bug (fixed)
css in dialog's content div
| Reported by: | mail@… | Owned by: | rdworth |
|---|---|---|---|
| Priority: | major | Milestone: | 1.7 |
| Component: | ui.dialog | Version: | 1.5.1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Content div of dialog has the same width as the whole dialog. Content may be cutted at the right side because of padding of content.
Change History (6)
comment:1 Changed 8 years ago by aaronchi
comment:2 Changed 8 years ago by scottgonzalez
- Owner changed from scott.gonzalez to rdworth
- Status changed from new to assigned
comment:3 Changed 8 years ago by Cloudream
- Milestone set to TDB
comment:4 Changed 8 years ago by silviogutierrez
This is especially problematic with the theme roller, which assigns padding to ui-dialog-content, guaranteeing overflow. This can be solved easily by changing this to "margin" since margin is what's taken into account on line 246 and 247 of ui.dialog.js v1.5.2.
The long term solution is to either make theme roller use margins instead of padding for the CSS class ui-dialog-content, or make ui.dialog.js taken padding into account as well as margin when calculating the dimensions of the dialog content.
Silvio
comment:5 Changed 8 years ago by scottgonzalez
- Resolution set to fixed
- Status changed from assigned to closed
Fixed with new CSS framework. We now only set width on the .ui-dialog div and only set height on the .ui-dialog-content div.
Feel free to re-open this ticket if you continue to have problems after 1.6rc3 with a new theme.
comment:6 Changed 8 years ago by scottgonzalez
- Milestone changed from TBD to 1.6
I suggest that the ui-dialog-content div should be placed inside of the div that is being used for the window. This way, the window div can be used to set the width/height and the inner content div can be styled independently.
I have the same problem right now. You can't assign a border/padding to the content div because it is being sized and so gets cut off.