Skip to main content

Search and Top Navigation

#3102 closed feature (notabug)

Opened July 16, 2008 12:01AM UTC

Closed September 13, 2012 09:00AM UTC

[scale-effect][patch] Add scale: 'textbox' option

Reported by: lrbabe Owned by: lrbabe
Priority: minor Milestone: 1.9.0
Component: ui.effects.* (individual effect) Version: 1.5.1
Keywords: scale textbox Cc:
Blocked by: Blocking:
Description

There are several reasons to change two lines of code in the scale effect. You should read the (very simple) attached patch first and then read the followings.

  • it saves two precious tests :)
  • it saves some precious bites of code :)
  • it shouldn't break anything
  • when using scale effect on an element containing sub element with dimensions only in % or em, you will want only the container dimensions and the text font-size to scale. Moreover, there are some bugs in the scale effect on element with % dimensions.

I have attached some kind of example to show that (unzip attached presentations, open them, use left arrow to go to next slide, right to go to previous): In the presentation without textbox, background images sometime disappear (go to previous slide), foreground images appear when they shouldn't (third slide)

I have named this option 'textbox' but I'm not proud of this name.

Regards,

lrbabe

Attachments (3)
Change History (8)

Changed July 16, 2008 05:58PM UTC by lrbabe comment:1

Even with the textbox option, there is still bugs in IE and firefox (not tested in safari). It seems that browsers really don't like those kinds of effects.

Changed August 17, 2008 10:15AM UTC by Cloudream comment:2

milestone: → TDB
priority: majorminor

Changed May 07, 2009 11:25AM UTC by jzaefferer comment:3

milestone: TBD1.7.2

Changed June 04, 2009 09:37AM UTC by rdworth comment:4

milestone: 1.7.21.8

Changed July 14, 2011 03:13AM UTC by gnarf comment:5

Replying to [comment:1 lrbabe]:

Is there any chance you can mock these presentations up with some fiddles, perhaps revisit this patch and submit a pull?

Changed June 26, 2012 01:22AM UTC by scottgonzalez comment:6

type: enhancementfeature

Changed August 29, 2012 04:47PM UTC by scottgonzalez comment:7

owner: → lrbabe
status: newpending

We'll need simpler test cases to look at.

Changed September 13, 2012 09:00AM UTC by trac-o-bot comment:8

resolution: → invalid
status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!