Opened 15 years ago
Closed 11 years ago
#3102 closed feature (notabug)
[scale-effect][patch] Add scale: 'textbox' option
Reported by: | lrbabe | Owned by: | lrbabe |
---|---|---|---|
Priority: | minor | Milestone: | 1.9.0 |
Component: | ui.effects.* (individual effect) | Version: | 1.5.1 |
Keywords: | scale textbox | Cc: | |
Blocked by: | Blocking: |
Description
There are several reasons to change two lines of code in the scale effect. You should read the (very simple) attached patch first and then read the followings.
- it saves two precious tests :)
- it saves some precious bites of code :)
- it shouldn't break anything
- when using scale effect on an element containing sub element with dimensions only in % or em, you will want only the container dimensions and the text font-size to scale. Moreover, there are some bugs in the scale effect on element with % dimensions.
I have attached some kind of example to show that (unzip attached presentations, open them, use left arrow to go to next slide, right to go to previous): In the presentation without textbox, background images sometime disappear (go to previous slide), foreground images appear when they shouldn't (third slide)
I have named this option 'textbox' but I'm not proud of this name.
Regards,
lrbabe
Attachments (3)
Change History (11)
Changed 15 years ago by
Attachment: | scale_patch.txt added |
---|
Changed 15 years ago by
Attachment: | presentation not using textbox.tar.gz added |
---|
Changed 15 years ago by
Attachment: | presentation using textbox.tar.gz added |
---|
comment:1 follow-up: 5 Changed 15 years ago by
comment:2 Changed 15 years ago by
Milestone: | → TDB |
---|---|
Priority: | major → minor |
comment:3 Changed 14 years ago by
Milestone: | TBD → 1.7.2 |
---|
comment:4 Changed 14 years ago by
Milestone: | 1.7.2 → 1.8 |
---|
comment:5 Changed 12 years ago by
Replying to lrbabe:
Is there any chance you can mock these presentations up with some fiddles, perhaps revisit this patch and submit a pull?
comment:6 Changed 11 years ago by
Type: | enhancement → feature |
---|
comment:7 Changed 11 years ago by
Owner: | set to lrbabe |
---|---|
Status: | new → pending |
We'll need simpler test cases to look at.
comment:8 Changed 11 years ago by
Resolution: | → invalid |
---|---|
Status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
Even with the textbox option, there is still bugs in IE and firefox (not tested in safari). It seems that browsers really don't like those kinds of effects.