Opened 12 years ago

Closed 7 years ago

#3102 closed feature (notabug)

[scale-effect][patch] Add scale: 'textbox' option

Reported by: lrbabe Owned by: lrbabe
Priority: minor Milestone: 1.9.0
Component: ui.effects.* (individual effect) Version: 1.5.1
Keywords: scale textbox Cc:
Blocked by: Blocking:

Description

There are several reasons to change two lines of code in the scale effect. You should read the (very simple) attached patch first and then read the followings.

  • it saves two precious tests :)
  • it saves some precious bites of code :)
  • it shouldn't break anything
  • when using scale effect on an element containing sub element with dimensions only in % or em, you will want only the container dimensions and the text font-size to scale. Moreover, there are some bugs in the scale effect on element with % dimensions.

I have attached some kind of example to show that (unzip attached presentations, open them, use left arrow to go to next slide, right to go to previous): In the presentation without textbox, background images sometime disappear (go to previous slide), foreground images appear when they shouldn't (third slide)

I have named this option 'textbox' but I'm not proud of this name.

Regards,
lrbabe

Attachments (3)

scale_patch.txt (1.1 KB) - added by lrbabe 12 years ago.
presentation not using textbox.tar.gz (229.9 KB) - added by lrbabe 12 years ago.
presentation using textbox.tar.gz (229.9 KB) - added by lrbabe 12 years ago.

Download all attachments as: .zip

Change History (11)

Changed 12 years ago by lrbabe

Attachment: scale_patch.txt added

Changed 12 years ago by lrbabe

Changed 12 years ago by lrbabe

comment:1 Changed 12 years ago by lrbabe

Even with the textbox option, there is still bugs in IE and firefox (not tested in safari). It seems that browsers really don't like those kinds of effects.

comment:2 Changed 12 years ago by Cloudream

Milestone: TDB
Priority: majorminor

comment:3 Changed 11 years ago by Jörn Zaefferer

Milestone: TBD1.7.2

comment:4 Changed 11 years ago by rdworth

Milestone: 1.7.21.8

comment:5 in reply to:  1 Changed 9 years ago by Corey Frang

Replying to lrbabe:

Is there any chance you can mock these presentations up with some fiddles, perhaps revisit this patch and submit a pull?

comment:6 Changed 8 years ago by Scott González

Type: enhancementfeature

comment:7 Changed 7 years ago by Scott González

Owner: set to lrbabe
Status: newpending

We'll need simpler test cases to look at.

comment:8 Changed 7 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.