Opened 15 years ago
Closed 14 years ago
#3117 closed bug (fixed)
fix for autoResize in dialog with button pane
Reported by: | mgl | Owned by: | rdworth |
---|---|---|---|
Priority: | major | Milestone: | 1.7 |
Component: | ui.dialog | Version: | 1.5.2 |
Keywords: | dialog buttonpane resize autoresize | Cc: | |
Blocked by: | Blocking: |
Description
I already posted this in the jQuery UI google group, but I figured it might be better to create a proper ticket. Here's what I posted on google groups:
I've got a dialog working, and I notice now that autoResize seems to be working to make the div that is contained by my dialog fit to the inside of the dialog properly...very nice. However, the problem I've got now is that it doesn't account for the height of the button pane if it is visible, so if I'm using the button pane, I have to disable autoResize, and implement the same workaround I've been using with the resize event...
So...here's my fix for the size method, which includes the button pane in the height calculation (starting at line 240):
size: function() {
var container = this.uiDialogContainer,
titlebar = this.uiDialogTitlebar, content = this.element, buttonpane = this.uiDialogButtonPane; tbMargin = parseInt(content.css('margin-top'),10) + parseInt(content.css('margin-bottom'),10), lrMargin = parseInt(content.css('margin-left'),10) + parseInt(content.css('margin-right'),10);
content.height(container.height() - titlebar.outerHeight() - buttonpane.outerHeight() - tbMargin); content.width(container.width() - lrMargin);
},
Change History (4)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
Owner: | changed from scott.gonzalez to rdworth |
---|---|
Status: | new → assigned |
Version: | 1.5.1 → 1.5.2 |
comment:3 Changed 14 years ago by
Milestone: | → TDB |
---|
comment:4 Changed 14 years ago by
Milestone: | TBD → 1.6 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
The autoResize option was removed in r1177. Dialogs now always auto-resize.
P.S.: This is with version 1.5.2, but that wasn't an option in this Trac.