Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#3188 closed bug (fixed)

prevent exposure of internal methods

Reported by: scottgonzalez Owned by: scottgonzalez
Priority: blocker Milestone: 1.6rc1
Component: ui.core Version: 1.5.2
Keywords: Cc:
Blocked by: Blocking:

Description

Internal plugin methods should not be callable using the plugin API.

Example:

$(el).plugin('internalMethod');

Change History (10)

comment:1 Changed 7 years ago by scottgonzalez

  • Status changed from new to accepted

This will be handled by the widget factory. Precede internal method names with an underscore to prevent exposure through the API.

comment:2 Changed 7 years ago by scottgonzalez

The widget factory was modified to support this in r547.

comment:3 Changed 7 years ago by scottgonzalez

  • Resolution set to fixed
  • Status changed from accepted to closed

There is a separate ticket for each plugin:

#3194 ui.accordion
#3195 ui.autocomplete
#3196 ui.colorpicker
#3197 ui.datepicker
#3198 ui.dialog
#3200 ui.draggable
#3201 ui.droppable
#3202 ui.magnifier
#3203 ui.progressbar
#3204 ui.resizable
#3205 ui.selectable
#3206 ui.slider
#3209 ui.sortable
#3207 ui.spinner
#3208 ui.tabs

comment:4 Changed 7 years ago by Cloudream

  • Resolution fixed deleted
  • Status changed from closed to reopened

After individual plugins fixed, we should fix init/plugins to _init/_plugins

comment:5 Changed 7 years ago by scottgonzalez

Widget factory methods updated in r552.

comment:6 Changed 7 years ago by Cloudream

only mouse* in drag/drop/sort/select left.

comment:7 Changed 7 years ago by Cloudream

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:8 Changed 7 years ago by scottgonzalez

  • Resolution fixed deleted
  • Status changed from closed to reopened

mouse* in slider still needs to be updated.

comment:9 Changed 7 years ago by Cloudream

  • Resolution set to fixed
  • Status changed from reopened to closed

done and pass the test case.

comment:10 Changed 7 years ago by rdworth

  • Milestone changed from 1.6 to 1.6rc1
Note: See TracTickets for help on using tickets.