Opened 7 years ago

Closed 7 years ago

#3451 closed enhancement (fixed)

ARIA work requires unique id for dialog title node.

Reported by: davidb Owned by: scottgonzalez
Priority: major Milestone: 1.7
Component: ui.dialog Version: 1.6rc1
Keywords: Cc: michelled
Blocked by: Blocking:

Description

We need to put an ARIA relation on the uiDialog node. This ARIA relation, aria-labelledby requires a value of 1 or more node ids. This allows the browser to build an accessible name for uiDialog from the nodes referred to by aria-labelledby. e.g. <div class="ui-dialog" role="dialog" labelledby="ui-dialog-title-unique-id"...

In discussing this with Scott we decided that a unique id needs to be generated for the title element of a jquery dialog.

Attachments (1)

labelledby.patch (1.5 KB) - added by scottgonzalez 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by scottgonzalez

comment:1 Changed 7 years ago by davidb

Scott, the patch looks great.

comment:2 Changed 7 years ago by davidb

...except, you don't need to add the ARIA yet. We're normalizing some util for ARIA in core. We're mostly there and will update you on the work. Dialog is out already first consumer of this API in our sandbox.

comment:3 Changed 7 years ago by scottgonzalez

  • Milestone changed from TBD to 1.6
  • Resolution set to fixed
  • Status changed from new to closed
  • Type changed from bug to enhancement

Fixed in r702.

Note: See TracTickets for help on using tickets.