Skip to main content

Search and Top Navigation

#3542 closed bug (fixed)

Opened November 06, 2008 01:13AM UTC

Closed December 19, 2008 01:10PM UTC

Last modified October 11, 2012 09:15PM UTC

Inline styles not removed after sorting

Reported by: antin Owned by: paul
Priority: minor Milestone:
Component: ui.sortable Version: 1.6rc2
Keywords: Cc:
Blocked by: Blocking:

This is related to ticket #3491. During the sort process a bunch of inline styles are applied to the element and while they are 'reset' they are not removed after the sorting is complete.

The particular issue I am having is due to the opacity being set during drag. Once the element has finished sorting jquery simply 'clears' the filter style, but actually leaves it there. Unfortunately as soon as the filter style is present (even if it is blank) IE 7 stops anti-aliasing the text.

Ticket #3491 has been closed and marked 'wontfix' which I believe to be a mistake. There is a very simple fix that would satisfy everyone.

At the very top of the _mouseStart function simply save a copy of the inline style on the element prior to sort:

o._style = $(this.currentItem).attr('style');

And then at the bottom of the _mouseStop function revert to the original style:

$(this.currentItem).attr('style', this.options._style);

This way the style can be modified without concern during the drag process and there is no need to 'carefully' undo all the minor changes at the end.

Attachments (0)
Change History (3)

Changed November 08, 2008 01:57PM UTC by scottgonzalez comment:1

component: ui.coreui.sortable

Changed December 19, 2008 01:10PM UTC by paul comment:2

resolution: → fixed
status: newclosed

Already fixed in a different way, but the result is the same :) Cheers, Paul

Changed October 11, 2012 09:15PM UTC by scottgonzalez comment:3

milestone: TBD

Milestone TBD deleted