Opened 11 years ago

Closed 8 years ago

#3553 closed bug (fixed)

Accordion needs keyboard and ARIA support

Reported by: davidb Owned by: davidb
Priority: major Milestone: 1.6
Component: [meta] ui.a11y Version: 1.6rc2
Keywords: Cc: michelled
Blocked by: Blocking:

Description

Currently accordion does not support a keyboard or screen reader interaction. We should fix this here so that jQuery users can benefit. This should probably be high priority given that it is locking out some features of the Mozilla addons website.

Blocks: mozilla bug 462411

Attachments (5)

taborder-based.diff (3.0 KB) - added by davidb 11 years ago.
the taborder based fix (removed unecessary aria-hidden)
3553.diff (3.7 KB) - added by davidb 11 years ago.
uses arrows. one header in tab order. removes header links from tab order needs review
3553.2.diff (3.8 KB) - added by davidb 11 years ago.
this one doesn't auto-expand when arrowing.
3553.3.diff (4.1 KB) - added by davidb 11 years ago.
makes sure at least one header in tab order, improved tabindex modification
3553toCommit.diff (4.1 KB) - added by davidb 11 years ago.
patch just committed to trunk. tested in FF2/3, Safari, IE8

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by davidb

Keywords: michelled added

When I get a chance, I'll post a patch that follows the http://dev.aol.com/dhtml_style_guide; unless we want to keep the 'every header is in the tab order' keyboard interaction. It will be a bit more work to follow the styleguide, and currently there is an agenda item to review an accordion proposal from James Craig, which I believe is more akin to the current patch.

Changed 11 years ago by davidb

Attachment: taborder-based.diff added

the taborder based fix (removed unecessary aria-hidden)

Changed 11 years ago by davidb

Attachment: 3553.diff added

uses arrows. one header in tab order. removes header links from tab order needs review

Changed 11 years ago by davidb

Attachment: 3553.2.diff added

this one doesn't auto-expand when arrowing.

Changed 11 years ago by davidb

Attachment: 3553.3.diff added

makes sure at least one header in tab order, improved tabindex modification

comment:2 Changed 11 years ago by davidb

Cc: michelled added
Keywords: michelled removed

Changed 11 years ago by davidb

Attachment: 3553toCommit.diff added

patch just committed to trunk. tested in FF2/3, Safari, IE8

comment:3 Changed 11 years ago by Scott González

Milestone: TBD1.next

comment:4 Changed 8 years ago by Scott González

Milestone: 1.next1.6
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.